* [PATCH] PCI: rcar-gen2: make of_device_ids const
@ 2017-06-23 9:29 Arvind Yadav
2017-06-23 9:41 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-06-23 9:29 UTC (permalink / raw)
To: horms, bhelgaas; +Cc: linux-pci, linux-kernel, linux-renesas-soc
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/pci/host/pci-rcar-gen2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
index 8534859..6f87968 100644
--- a/drivers/pci/host/pci-rcar-gen2.c
+++ b/drivers/pci/host/pci-rcar-gen2.c
@@ -429,7 +429,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
return 0;
}
-static struct of_device_id rcar_pci_of_match[] = {
+static const struct of_device_id rcar_pci_of_match[] = {
{ .compatible = "renesas,pci-r8a7790", },
{ .compatible = "renesas,pci-r8a7791", },
{ .compatible = "renesas,pci-r8a7794", },
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar-gen2: make of_device_ids const
2017-06-23 9:29 [PATCH] PCI: rcar-gen2: make of_device_ids const Arvind Yadav
@ 2017-06-23 9:41 ` Simon Horman
2017-06-26 8:11 ` Geert Uytterhoeven
2017-07-02 21:46 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2017-06-23 9:41 UTC (permalink / raw)
To: Arvind Yadav; +Cc: bhelgaas, linux-pci, linux-kernel, linux-renesas-soc
On Fri, Jun 23, 2017 at 02:59:52PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/pci/host/pci-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index 8534859..6f87968 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -429,7 +429,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id rcar_pci_of_match[] = {
> +static const struct of_device_id rcar_pci_of_match[] = {
> { .compatible = "renesas,pci-r8a7790", },
> { .compatible = "renesas,pci-r8a7791", },
> { .compatible = "renesas,pci-r8a7794", },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar-gen2: make of_device_ids const
2017-06-23 9:29 [PATCH] PCI: rcar-gen2: make of_device_ids const Arvind Yadav
2017-06-23 9:41 ` Simon Horman
@ 2017-06-26 8:11 ` Geert Uytterhoeven
2017-07-02 21:46 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-06-26 8:11 UTC (permalink / raw)
To: Arvind Yadav
Cc: Simon Horman, Bjorn Helgaas, linux-pci, linux-kernel, Linux-Renesas
On Fri, Jun 23, 2017 at 11:29 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar-gen2: make of_device_ids const
2017-06-23 9:29 [PATCH] PCI: rcar-gen2: make of_device_ids const Arvind Yadav
2017-06-23 9:41 ` Simon Horman
2017-06-26 8:11 ` Geert Uytterhoeven
@ 2017-07-02 21:46 ` Bjorn Helgaas
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2017-07-02 21:46 UTC (permalink / raw)
To: Arvind Yadav; +Cc: horms, bhelgaas, linux-pci, linux-kernel, linux-renesas-soc
On Fri, Jun 23, 2017 at 02:59:52PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied with acks from Simon & Geert to pci/host-rcar for v4.13, thanks!
> ---
> drivers/pci/host/pci-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index 8534859..6f87968 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -429,7 +429,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id rcar_pci_of_match[] = {
> +static const struct of_device_id rcar_pci_of_match[] = {
> { .compatible = "renesas,pci-r8a7790", },
> { .compatible = "renesas,pci-r8a7791", },
> { .compatible = "renesas,pci-r8a7794", },
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-02 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 9:29 [PATCH] PCI: rcar-gen2: make of_device_ids const Arvind Yadav
2017-06-23 9:41 ` Simon Horman
2017-06-26 8:11 ` Geert Uytterhoeven
2017-07-02 21:46 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).