* [PATCH v2] staging: sm750fb: fixed a assignment typo
@ 2017-07-03 8:13 Lynn Lei
2017-07-03 8:30 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Lynn Lei @ 2017-07-03 8:13 UTC (permalink / raw)
To: gregkh; +Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-kernel
fixed a typo issue in get_mxclk_freq().
the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
which is not right, it should be PLL_CTRL_N_SHIFT.
both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
defined in drivers/staging/sm750fb/ddk750_reg.h
Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 5e4bfb601cea..c51761221131 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -40,7 +40,7 @@ static unsigned int get_mxclk_freq(void)
pll_reg = peek32(MXCLK_PLL_CTRL);
M = (pll_reg & PLL_CTRL_M_MASK) >> PLL_CTRL_M_SHIFT;
- N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_M_SHIFT;
+ N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_N_SHIFT;
OD = (pll_reg & PLL_CTRL_OD_MASK) >> PLL_CTRL_OD_SHIFT;
POD = (pll_reg & PLL_CTRL_POD_MASK) >> PLL_CTRL_POD_SHIFT;
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: sm750fb: fixed a assignment typo
2017-07-03 8:13 [PATCH v2] staging: sm750fb: fixed a assignment typo Lynn Lei
@ 2017-07-03 8:30 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-07-03 8:30 UTC (permalink / raw)
To: Lynn Lei; +Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-kernel
On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote:
> fixed a typo issue in get_mxclk_freq().
>
> the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
> which is not right, it should be PLL_CTRL_N_SHIFT.
>
> both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
> defined in drivers/staging/sm750fb/ddk750_reg.h
>
> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Always put what changed from the previous version here below the ---
line, like the Documentation states to do.
v3 please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-03 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03 8:13 [PATCH v2] staging: sm750fb: fixed a assignment typo Lynn Lei
2017-07-03 8:30 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).