* [PATCH] cpufreq: cpufreq_stats: constify attribute_group structures.
@ 2017-07-03 7:59 Arvind Yadav
2017-07-03 9:00 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-03 7:59 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: linux-pm, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
1655 256 4 1915 77b drivers/cpufreq/cpufreq_stats.o
File size After adding 'const':
text data bss dec hex filename
1695 192 4 1891 763 drivers/cpufreq/cpufreq_stats.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/cpufreq/cpufreq_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index f570ead..d362739 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -135,7 +135,7 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf)
&trans_table.attr,
NULL
};
-static struct attribute_group stats_attr_group = {
+static const struct attribute_group stats_attr_group = {
.attrs = default_attrs,
.name = "stats"
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: cpufreq_stats: constify attribute_group structures.
2017-07-03 7:59 [PATCH] cpufreq: cpufreq_stats: constify attribute_group structures Arvind Yadav
@ 2017-07-03 9:00 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2017-07-03 9:00 UTC (permalink / raw)
To: Arvind Yadav; +Cc: rjw, linux-pm, linux-kernel
On 03-07-17, 13:29, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 1655 256 4 1915 77b drivers/cpufreq/cpufreq_stats.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1695 192 4 1891 763 drivers/cpufreq/cpufreq_stats.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/cpufreq/cpufreq_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> index f570ead..d362739 100644
> --- a/drivers/cpufreq/cpufreq_stats.c
> +++ b/drivers/cpufreq/cpufreq_stats.c
> @@ -135,7 +135,7 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf)
> &trans_table.attr,
> NULL
> };
> -static struct attribute_group stats_attr_group = {
> +static const struct attribute_group stats_attr_group = {
> .attrs = default_attrs,
> .name = "stats"
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-03 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03 7:59 [PATCH] cpufreq: cpufreq_stats: constify attribute_group structures Arvind Yadav
2017-07-03 9:00 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).