From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rmem: support for dma_addr different from phys_addr
Date: Tue, 4 Jul 2017 12:43:59 +0200 [thread overview]
Message-ID: <20170704104359.GB29883@kroah.com> (raw)
In-Reply-To: <20170704103438.21628-1-vladimir.kondratiev@intel.com>
On Tue, Jul 04, 2017 at 01:34:38PM +0300, Vladimir Kondratiev wrote:
> On some systems, dma address differs from physical one due to
> various reasons.
>
> dma_init_coherent_memory is aware of it, it takes both
> phys_addr_t and dma_addt_t arguments for memory block.
> However, rmem_dma_device_init passes physical address for DMA one.
>
> Fix this, using phys_to_dma(). This assumes the whole buffer has
> same offset between physical and dma addresses.
>
> Change-Id: Ic709312941ee4e1a37afb2ea25cbd759eabc009b
What is that line for? You didn't use checkpatch.pl :(
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
Ok, this is getting really annoying, according to my lawyers, I have to
never respond to emails with this in it, and should just delete it. But
I'll be nice, and tell you all to go fix all of Intel's email system to
never send this stuff out again, it keeps happening over and over and
over and is preventing you from contributing to open source projects.
email is now deleted.
greg k-h
next prev parent reply other threads:[~2017-07-04 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 10:34 [PATCH] rmem: support for dma_addr different from phys_addr Vladimir Kondratiev
2017-07-04 10:43 ` Greg Kroah-Hartman [this message]
2017-07-04 12:50 Vladimir Kondratiev
2017-07-05 19:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704104359.GB29883@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir.kondratiev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).