* [PATCH] pwm: cros-ec: fix transposed param settings
@ 2017-06-23 21:52 Nick Vaccaro
2017-07-06 8:16 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Nick Vaccaro @ 2017-06-23 21:52 UTC (permalink / raw)
To: ThierryRediny.reding; +Cc: linux-pwm, linux-kernel
The __cros_ec_pwm_get_duty() routine was transposing the insize and
outsize fields when calling cros_ec_cmd_xfer_status().
The original code worked without error due to size of the two particular
parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is
not fixing an actual runtime problem, just correcting the calling usage.
Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
---
drivers/pwm/pwm-cros-ec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
index 2e4ab20cfb83..de5b7c9860b6 100644
--- a/drivers/pwm/pwm-cros-ec.c
+++ b/drivers/pwm/pwm-cros-ec.c
@@ -75,8 +75,8 @@ static int __cros_ec_pwm_get_duty(struct cros_ec_device *ec, u8 index,
msg->version = 0;
msg->command = EC_CMD_PWM_GET_DUTY;
- msg->insize = sizeof(*params);
- msg->outsize = sizeof(*resp);
+ msg->insize = sizeof(*resp);
+ msg->outsize = sizeof(*params);
params->pwm_type = EC_PWM_TYPE_GENERIC;
params->index = index;
--
2.13.1.518.g3df882009-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: cros-ec: fix transposed param settings
2017-06-23 21:52 [PATCH] pwm: cros-ec: fix transposed param settings Nick Vaccaro
@ 2017-07-06 8:16 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2017-07-06 8:16 UTC (permalink / raw)
To: Nick Vaccaro; +Cc: linux-pwm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Fri, Jun 23, 2017 at 02:52:47PM -0700, Nick Vaccaro wrote:
> The __cros_ec_pwm_get_duty() routine was transposing the insize and
> outsize fields when calling cros_ec_cmd_xfer_status().
>
> The original code worked without error due to size of the two particular
> parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is
> not fixing an actual runtime problem, just correcting the calling usage.
>
> Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> ---
> drivers/pwm/pwm-cros-ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-06 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 21:52 [PATCH] pwm: cros-ec: fix transposed param settings Nick Vaccaro
2017-07-06 8:16 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).