* [PATCH] ARM: sunxi: h3/h5: Correct emac register size
@ 2017-07-06 8:53 Corentin Labbe
2017-07-06 18:52 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Corentin Labbe @ 2017-07-06 8:53 UTC (permalink / raw)
To: robh+dt, mark.rutland, linux, maxime.ripard, wens
Cc: devicetree, linux-arm-kernel, linux-kernel, Corentin Labbe
The datasheet said that emac register size is 0x1000 not 0x104
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 716e7d668dec..5a57b67c9b77 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -406,7 +406,7 @@
emac: ethernet@1c30000 {
compatible = "allwinner,sun8i-h3-emac";
syscon = <&syscon>;
- reg = <0x01c30000 0x104>;
+ reg = <0x01c30000 0x1000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq";
resets = <&ccu RST_BUS_EMAC>;
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size
2017-07-06 8:53 [PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe
@ 2017-07-06 18:52 ` Maxime Ripard
2017-07-06 19:05 ` Corentin Labbe
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2017-07-06 18:52 UTC (permalink / raw)
To: Corentin Labbe
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> The datasheet said that emac register size is 0x1000 not 0x104
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 716e7d668dec..5a57b67c9b77 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -406,7 +406,7 @@
> emac: ethernet@1c30000 {
> compatible = "allwinner,sun8i-h3-emac";
> syscon = <&syscon>;
> - reg = <0x01c30000 0x104>;
> + reg = <0x01c30000 0x1000>;
The size is actually 0x10000. I fixed it and applied.
The A64 DTSI has the same issue, can you send a patch for this one
too?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size
2017-07-06 18:52 ` Maxime Ripard
@ 2017-07-06 19:05 ` Corentin Labbe
0 siblings, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2017-07-06 19:05 UTC (permalink / raw)
To: Maxime Ripard
Cc: robh+dt, mark.rutland, linux, wens, devicetree, linux-arm-kernel,
linux-kernel
On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> > emac: ethernet@1c30000 {
> > compatible = "allwinner,sun8i-h3-emac";
> > syscon = <&syscon>;
> > - reg = <0x01c30000 0x104>;
> > + reg = <0x01c30000 0x1000>;
>
> The size is actually 0x10000. I fixed it and applied.
>
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
>
Yes
Thanks for the fixing
Regards
Corentin Labbe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-06 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 8:53 [PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe
2017-07-06 18:52 ` Maxime Ripard
2017-07-06 19:05 ` Corentin Labbe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).