From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
David Wayne Fugate <david.fugate@intel.com>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk
Date: Fri, 7 Jul 2017 01:22:53 +0200 [thread overview]
Message-ID: <20170706232253.GA11119@lst.de> (raw)
In-Reply-To: <20170706223955.GA1200@localhost.localdomain>
On Thu, Jul 06, 2017 at 06:39:56PM -0400, Keith Busch wrote:
> That's true for all Intel controllers going forward, but this
> is actually an older controller that pre-dates NOIOB. It's the exact
> same as the 8086:0A54 model, but a particular vendor decided their
> rebranded device needs to be made special with a different DID.
Meh..
>
> We all agree that's a terrible way to go about this for mutliple reasons,
> but we can't go back in time to tell the decision makers of this folly. So
> I think we need to let this last one go through with the quirk.
>
> Acked-by: Keith Busch <keith.busch@intel.com>
Reluctantly-accepted-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-07-06 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1499379151-32479-1-git-send-email-david.fugate@intel.com>
2017-07-06 22:17 ` [PATCH] NVMe: Added another device ID with stripe quirk Christoph Hellwig
2017-07-06 22:39 ` Keith Busch
2017-07-06 23:22 ` Christoph Hellwig [this message]
2017-07-10 5:52 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706232253.GA11119@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=david.fugate@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).