From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>
Cc: David Wayne Fugate <david.fugate@intel.com>,
Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk
Date: Mon, 10 Jul 2017 08:52:09 +0300 [thread overview]
Message-ID: <a01eeb47-7566-05fb-4d8b-db5ddef36b82@grimberg.me> (raw)
In-Reply-To: <20170706232253.GA11119@lst.de>
>> That's true for all Intel controllers going forward, but this
>> is actually an older controller that pre-dates NOIOB. It's the exact
>> same as the 8086:0A54 model, but a particular vendor decided their
>> rebranded device needs to be made special with a different DID.
>
> Meh..
>
>>
>> We all agree that's a terrible way to go about this for mutliple reasons,
>> but we can't go back in time to tell the decision makers of this folly. So
>> I think we need to let this last one go through with the quirk.
>>
>> Acked-by: Keith Busch <keith.busch@intel.com>
>
> Reluctantly-accepted-by: Christoph Hellwig <hch@lst.de>
>
David, can you resend the patch? For some reason I
can't locate it in my mailbox...
prev parent reply other threads:[~2017-07-10 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1499379151-32479-1-git-send-email-david.fugate@intel.com>
2017-07-06 22:17 ` [PATCH] NVMe: Added another device ID with stripe quirk Christoph Hellwig
2017-07-06 22:39 ` Keith Busch
2017-07-06 23:22 ` Christoph Hellwig
2017-07-10 5:52 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a01eeb47-7566-05fb-4d8b-db5ddef36b82@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=david.fugate@intel.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).