* [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value
@ 2017-07-07 6:16 Gustavo A. R. Silva
2017-07-07 9:25 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:16 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Jonathan Hunter
Cc: dri-devel, linux-tegra, linux-kernel, Gustavo A. R. Silva
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/gpu/drm/tegra/vic.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
index 47cb1aa..7e11825 100644
--- a/drivers/gpu/drm/tegra/vic.c
+++ b/drivers/gpu/drm/tegra/vic.c
@@ -283,6 +283,11 @@ static int vic_probe(struct platform_device *pdev)
int err;
match = of_match_device(vic_match, dev);
+ if (!match) {
+ dev_err(&pdev->dev, "failed to match device\n");
+ return -ENODEV;
+ }
+
vic_config = (struct vic_config *)match->data;
vic = devm_kzalloc(dev, sizeof(*vic), GFP_KERNEL);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value
2017-07-07 6:16 [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value Gustavo A. R. Silva
@ 2017-07-07 9:25 ` Thierry Reding
2017-07-10 19:29 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2017-07-07 9:25 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: David Airlie, Jonathan Hunter, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On Fri, Jul 07, 2017 at 01:16:26AM -0500, Gustavo A. R. Silva wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/gpu/drm/tegra/vic.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 47cb1aa..7e11825 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -283,6 +283,11 @@ static int vic_probe(struct platform_device *pdev)
> int err;
>
> match = of_match_device(vic_match, dev);
> + if (!match) {
> + dev_err(&pdev->dev, "failed to match device\n");
> + return -ENODEV;
> + }
Someone would have to go to great lengths to trigger this condition,
might as well let it crash as a warning that they've done something
wrong.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value
2017-07-07 9:25 ` Thierry Reding
@ 2017-07-10 19:29 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-10 19:29 UTC (permalink / raw)
To: Thierry Reding
Cc: David Airlie, Jonathan Hunter, dri-devel, linux-tegra, linux-kernel
Hi Thierry,
Quoting Thierry Reding <thierry.reding@gmail.com>:
> On Fri, Jul 07, 2017 at 01:16:26AM -0500, Gustavo A. R. Silva wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/gpu/drm/tegra/vic.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
>> index 47cb1aa..7e11825 100644
>> --- a/drivers/gpu/drm/tegra/vic.c
>> +++ b/drivers/gpu/drm/tegra/vic.c
>> @@ -283,6 +283,11 @@ static int vic_probe(struct platform_device *pdev)
>> int err;
>>
>> match = of_match_device(vic_match, dev);
>> + if (!match) {
>> + dev_err(&pdev->dev, "failed to match device\n");
>> + return -ENODEV;
>> + }
>
> Someone would have to go to great lengths to trigger this condition,
> might as well let it crash as a warning that they've done something
> wrong.
>
Thanks for clarifying.
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-10 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 6:16 [PATCH] drm/tegra: vic: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-07 9:25 ` Thierry Reding
2017-07-10 19:29 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).