* [PATCH] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers
@ 2017-07-07 13:56 Ludovic Desroches
2017-07-08 23:27 ` kbuild test robot
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Desroches @ 2017-07-07 13:56 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: nicolas.ferre, alexandre.belloni, boris.brezillon, Ludovic Desroches
Use pin macros instead of magic numbers to ease interpretation.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index 2e2c3d1a1fa2..8dc436631b8d 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -68,7 +68,7 @@
ahb {
usb0: gadget@00300000 {
- atmel,vbus-gpio = <&pioA 31 GPIO_ACTIVE_HIGH>;
+ atmel,vbus-gpio = <&pioA PIN_PA31 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usba_vbus>;
status = "okay";
@@ -76,8 +76,8 @@
usb1: ohci@00400000 {
num-ports = <3>;
- atmel,vbus-gpio = <0 /* &pioA 41 GPIO_ACTIVE_HIGH */
- &pioA 42 GPIO_ACTIVE_HIGH
+ atmel,vbus-gpio = <0 /* &pioA PIN_PB9 GPIO_ACTIVE_HIGH */
+ &pioA PIN_PB10 GPIO_ACTIVE_HIGH
0
>;
pinctrl-names = "default";
@@ -127,7 +127,7 @@
ethernet-phy@1 {
reg = <0x1>;
interrupt-parent = <&pioA>;
- interrupts = <73 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <PIN_PC9 IRQ_TYPE_LEVEL_LOW>;
};
};
@@ -160,9 +160,9 @@
compatible = "active-semi,act8945a";
reg = <0x5b>;
active-semi,vsel-high;
- active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
- active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
- active-semi,irq_gpios = <&pioA 45 GPIO_ACTIVE_LOW>;
+ active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
+ active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
+ active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
active-semi,input-voltage-threshold-microvolt = <6600>;
active-semi,precondition-timeout = <40>;
active-semi,total-timeout = <3>;
@@ -504,7 +504,7 @@
bp1 {
label = "PB_USER";
- gpios = <&pioA 41 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB9 GPIO_ACTIVE_LOW>;
linux,code = <0x104>;
};
};
@@ -517,17 +517,17 @@
red {
label = "red";
- gpios = <&pioA 38 GPIO_ACTIVE_LOW>;
- };
+ gpios = <&pioA PIN_PB6 GPIO_ACTIVE_LOW>;
+
green {
label = "green";
- gpios = <&pioA 37 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB5 GPIO_ACTIVE_LOW>;
};
blue {
label = "blue";
- gpios = <&pioA 32 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
--
2.12.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers
2017-07-07 13:56 [PATCH] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers Ludovic Desroches
@ 2017-07-08 23:27 ` kbuild test robot
2017-07-10 6:12 ` [PATCH v2] " Ludovic Desroches
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2017-07-08 23:27 UTC (permalink / raw)
To: Ludovic Desroches
Cc: kbuild-all, linux-arm-kernel, devicetree, linux-kernel,
nicolas.ferre, alexandre.belloni, boris.brezillon,
Ludovic Desroches
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
Hi Ludovic,
[auto build test ERROR on at91/at91-next]
[also build test ERROR on v4.12 next-20170707]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ludovic-Desroches/ARM-dts-at91-sama5d2_xplained-use-pin-macros-instead-of-numbers/20170709-040631
base: https://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git at91-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/at91-sama5d2_xplained.dts:538.3-539.1 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22770 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers
2017-07-08 23:27 ` kbuild test robot
@ 2017-07-10 6:12 ` Ludovic Desroches
2017-07-13 11:56 ` Nicolas Ferre
2017-07-17 9:15 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Desroches @ 2017-07-10 6:12 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: nicolas.ferre, alexandre.belloni, boris.brezillon, Ludovic Desroches
Use pin macros instead of magic numbers to ease interpretation.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
I have remove the unexpected brace removal from the first version of this patch.
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index 2e2c3d1a1fa2..6eec8dc5143e 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -68,7 +68,7 @@
ahb {
usb0: gadget@00300000 {
- atmel,vbus-gpio = <&pioA 31 GPIO_ACTIVE_HIGH>;
+ atmel,vbus-gpio = <&pioA PIN_PA31 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usba_vbus>;
status = "okay";
@@ -76,8 +76,8 @@
usb1: ohci@00400000 {
num-ports = <3>;
- atmel,vbus-gpio = <0 /* &pioA 41 GPIO_ACTIVE_HIGH */
- &pioA 42 GPIO_ACTIVE_HIGH
+ atmel,vbus-gpio = <0 /* &pioA PIN_PB9 GPIO_ACTIVE_HIGH */
+ &pioA PIN_PB10 GPIO_ACTIVE_HIGH
0
>;
pinctrl-names = "default";
@@ -127,7 +127,7 @@
ethernet-phy@1 {
reg = <0x1>;
interrupt-parent = <&pioA>;
- interrupts = <73 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <PIN_PC9 IRQ_TYPE_LEVEL_LOW>;
};
};
@@ -160,9 +160,9 @@
compatible = "active-semi,act8945a";
reg = <0x5b>;
active-semi,vsel-high;
- active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
- active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
- active-semi,irq_gpios = <&pioA 45 GPIO_ACTIVE_LOW>;
+ active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
+ active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
+ active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
active-semi,input-voltage-threshold-microvolt = <6600>;
active-semi,precondition-timeout = <40>;
active-semi,total-timeout = <3>;
@@ -504,7 +504,7 @@
bp1 {
label = "PB_USER";
- gpios = <&pioA 41 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB9 GPIO_ACTIVE_LOW>;
linux,code = <0x104>;
};
};
@@ -517,17 +517,18 @@
red {
label = "red";
- gpios = <&pioA 38 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB6 GPIO_ACTIVE_LOW>;
};
+
green {
label = "green";
- gpios = <&pioA 37 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB5 GPIO_ACTIVE_LOW>;
};
blue {
label = "blue";
- gpios = <&pioA 32 GPIO_ACTIVE_LOW>;
+ gpios = <&pioA PIN_PB0 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
--
2.12.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers
2017-07-10 6:12 ` [PATCH v2] " Ludovic Desroches
@ 2017-07-13 11:56 ` Nicolas Ferre
2017-07-17 9:15 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2017-07-13 11:56 UTC (permalink / raw)
To: Ludovic Desroches, linux-arm-kernel, devicetree, linux-kernel,
alexandre.belloni
Cc: boris.brezillon
On 10/07/2017 at 08:12, Ludovic Desroches wrote:
> Use pin macros instead of magic numbers to ease interpretation.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
>
> I have remove the unexpected brace removal from the first version of this patch.
>
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 2e2c3d1a1fa2..6eec8dc5143e 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -68,7 +68,7 @@
>
> ahb {
> usb0: gadget@00300000 {
> - atmel,vbus-gpio = <&pioA 31 GPIO_ACTIVE_HIGH>;
> + atmel,vbus-gpio = <&pioA PIN_PA31 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usba_vbus>;
> status = "okay";
> @@ -76,8 +76,8 @@
>
> usb1: ohci@00400000 {
> num-ports = <3>;
> - atmel,vbus-gpio = <0 /* &pioA 41 GPIO_ACTIVE_HIGH */
> - &pioA 42 GPIO_ACTIVE_HIGH
> + atmel,vbus-gpio = <0 /* &pioA PIN_PB9 GPIO_ACTIVE_HIGH */
> + &pioA PIN_PB10 GPIO_ACTIVE_HIGH
> 0
> >;
> pinctrl-names = "default";
> @@ -127,7 +127,7 @@
> ethernet-phy@1 {
> reg = <0x1>;
> interrupt-parent = <&pioA>;
> - interrupts = <73 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <PIN_PC9 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> @@ -160,9 +160,9 @@
> compatible = "active-semi,act8945a";
> reg = <0x5b>;
> active-semi,vsel-high;
> - active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
> - active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
> - active-semi,irq_gpios = <&pioA 45 GPIO_ACTIVE_LOW>;
> + active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
> + active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
> + active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
> active-semi,input-voltage-threshold-microvolt = <6600>;
> active-semi,precondition-timeout = <40>;
> active-semi,total-timeout = <3>;
> @@ -504,7 +504,7 @@
>
> bp1 {
> label = "PB_USER";
> - gpios = <&pioA 41 GPIO_ACTIVE_LOW>;
> + gpios = <&pioA PIN_PB9 GPIO_ACTIVE_LOW>;
> linux,code = <0x104>;
> };
> };
> @@ -517,17 +517,18 @@
>
> red {
> label = "red";
> - gpios = <&pioA 38 GPIO_ACTIVE_LOW>;
> + gpios = <&pioA PIN_PB6 GPIO_ACTIVE_LOW>;
> };
>
> +
> green {
> label = "green";
> - gpios = <&pioA 37 GPIO_ACTIVE_LOW>;
> + gpios = <&pioA PIN_PB5 GPIO_ACTIVE_LOW>;
> };
>
> blue {
> label = "blue";
> - gpios = <&pioA 32 GPIO_ACTIVE_LOW>;
> + gpios = <&pioA PIN_PB0 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers
2017-07-10 6:12 ` [PATCH v2] " Ludovic Desroches
2017-07-13 11:56 ` Nicolas Ferre
@ 2017-07-17 9:15 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2017-07-17 9:15 UTC (permalink / raw)
To: Ludovic Desroches
Cc: linux-arm-kernel, devicetree, linux-kernel, nicolas.ferre,
boris.brezillon
On 10/07/2017 at 08:12:05 +0200, Ludovic Desroches wrote:
> Use pin macros instead of magic numbers to ease interpretation.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>
> I have remove the unexpected brace removal from the first version of this patch.
>
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-17 9:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 13:56 [PATCH] ARM: dts: at91: sama5d2_xplained: use pin macros instead of numbers Ludovic Desroches
2017-07-08 23:27 ` kbuild test robot
2017-07-10 6:12 ` [PATCH v2] " Ludovic Desroches
2017-07-13 11:56 ` Nicolas Ferre
2017-07-17 9:15 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).