* [PATCH] usb: gadget: fusb300_udc: compress return logic into one line
@ 2017-07-10 3:10 Gustavo A. R. Silva
0 siblings, 0 replies; only message in thread
From: Gustavo A. R. Silva @ 2017-07-10 3:10 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Gustavo A. R. Silva
Simplify return logic to avoid unnecessary variable declaration
and assignment.
These issues were detected using Coccinelle and the following
semantic patch:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/gadget/udc/fusb300_udc.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c
index e0c1b00..8738f03 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.c
+++ b/drivers/usb/gadget/udc/fusb300_udc.c
@@ -659,22 +659,16 @@ static void fusb300_rdfifo(struct fusb300_ep *ep,
static u8 fusb300_get_epnstall(struct fusb300 *fusb300, u8 ep)
{
- u8 value;
u32 reg = ioread32(fusb300->reg + FUSB300_OFFSET_EPSET0(ep));
- value = reg & FUSB300_EPSET0_STL;
-
- return value;
+ return reg & FUSB300_EPSET0_STL;
}
static u8 fusb300_get_cxstall(struct fusb300 *fusb300)
{
- u8 value;
u32 reg = ioread32(fusb300->reg + FUSB300_OFFSET_CSR);
- value = (reg & FUSB300_CSR_STL) >> 1;
-
- return value;
+ return (reg & FUSB300_CSR_STL) >> 1;
}
static void request_error(struct fusb300 *fusb300)
--
2.5.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-10 3:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 3:10 [PATCH] usb: gadget: fusb300_udc: compress return logic into one line Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).