* [PATCH] binfmt_flat: fix format string for u32
@ 2017-07-10 11:08 Arnd Bergmann
2017-07-10 15:49 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-07-10 11:08 UTC (permalink / raw)
To: Alexander Viro
Cc: Arnd Bergmann, Greg Ungerer, Nicolas Pitre, linux-fsdevel, linux-kernel
The types have changed from 'unsigned long' to 'u32', so now the
format string is wrong, and produces a harmless warning on arm32:
arm-soc/fs/binfmt_flat.c: In function 'load_flat_file':
arm-soc/fs/binfmt_flat.c:577:25: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'u32 {aka unsigned int}' [-Werror=format=]
This changes it to '%d' instead, matching the 'u32' type.
Fixes: 468138d78510 ("binfmt_flat: flat_{get,put}_addr_from_rp() should be able to fail")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/binfmt_flat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 69ec23daa25e..96a06197f83a 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
MAX_SHARED_LIBS * sizeof(unsigned long),
FLAT_DATA_ALIGN);
- pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
+ pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
data_len + bss_len + stack_len, datapos);
fpos = ntohl(hdr->data_start);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] binfmt_flat: fix format string for u32
2017-07-10 11:08 [PATCH] binfmt_flat: fix format string for u32 Arnd Bergmann
@ 2017-07-10 15:49 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2017-07-10 15:49 UTC (permalink / raw)
To: Arnd Bergmann, Alexander Viro
Cc: Greg Ungerer, Nicolas Pitre, linux-fsdevel, linux-kernel
On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote:
> The types have changed from 'unsigned long' to 'u32', so now the
> format string is wrong, and produces a harmless warning on arm32:
[]
> This changes it to '%d' instead, matching the 'u32' type.
[]
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
[]
> @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
> MAX_SHARED_LIBS * sizeof(unsigned long),
> FLAT_DATA_ALIGN);
>
> - pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
> + pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
> data_len + bss_len + stack_len, datapos);
Ideally, %u not %d as data_len, bss_len and stack_len are all u32
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-10 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 11:08 [PATCH] binfmt_flat: fix format string for u32 Arnd Bergmann
2017-07-10 15:49 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).