* [PATCH] ata: fix gemini Kconfig dependencies
@ 2017-07-10 8:51 Arnd Bergmann
2017-07-10 17:43 ` Tejun Heo
2017-07-11 14:29 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-07-10 8:51 UTC (permalink / raw)
To: Tejun Heo
Cc: Arnd Bergmann, Bartlomiej Zolnierkiewicz, Geert Uytterhoeven,
Linus Walleij, linux-ide, linux-kernel
We cannot build the new ftide010 code without also building the faraday
sata bridge driver:
drivers/ata/pata_ftide010.o: In function `pata_ftide010_probe':
pata_ftide010.c:(.text+0x2b8): undefined reference to `gemini_sata_bridge_get'
pata_ftide010.c:(.text+0x32c): undefined reference to `gemini_sata_get_muxmode'
pata_ftide010.c:(.text+0x358): undefined reference to `gemini_sata_bridge_enabled'
drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_stop':
pata_ftide010.c:(.text+0x520): undefined reference to `gemini_sata_stop_bridge'
drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_start':
pata_ftide010.c:(.text+0x5bc): undefined reference to `gemini_sata_start_bridge'
This adjusts the Kconfig dependencies accordingly.
Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 948fc86980a1..363fc5330c21 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -215,7 +215,7 @@ config SATA_FSL
config SATA_GEMINI
tristate "Gemini SATA bridge support"
- depends on PATA_FTIDE010
+ depends on ARCH_GEMINI || COMPILE_TEST
default ARCH_GEMINI
help
This enabled support for the FTIDE010 to SATA bridge
@@ -613,7 +613,7 @@ config PATA_FTIDE010
tristate "Faraday Technology FTIDE010 PATA support"
depends on OF
depends on ARM
- default ARCH_GEMINI
+ depends on SATA_GEMINI
help
This option enables support for the Faraday FTIDE010
PATA controller found in the Cortina Gemini SoCs.
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: fix gemini Kconfig dependencies
2017-07-10 8:51 [PATCH] ata: fix gemini Kconfig dependencies Arnd Bergmann
@ 2017-07-10 17:43 ` Tejun Heo
2017-07-11 14:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2017-07-10 17:43 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz, Geert Uytterhoeven, Linus Walleij,
linux-ide, linux-kernel
On Mon, Jul 10, 2017 at 10:51:02AM +0200, Arnd Bergmann wrote:
> We cannot build the new ftide010 code without also building the faraday
> sata bridge driver:
>
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_probe':
> pata_ftide010.c:(.text+0x2b8): undefined reference to `gemini_sata_bridge_get'
> pata_ftide010.c:(.text+0x32c): undefined reference to `gemini_sata_get_muxmode'
> pata_ftide010.c:(.text+0x358): undefined reference to `gemini_sata_bridge_enabled'
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_stop':
> pata_ftide010.c:(.text+0x520): undefined reference to `gemini_sata_stop_bridge'
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_start':
> pata_ftide010.c:(.text+0x5bc): undefined reference to `gemini_sata_start_bridge'
>
> This adjusts the Kconfig dependencies accordingly.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to libata/for-4.13-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: fix gemini Kconfig dependencies
2017-07-10 8:51 [PATCH] ata: fix gemini Kconfig dependencies Arnd Bergmann
2017-07-10 17:43 ` Tejun Heo
@ 2017-07-11 14:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-07-11 14:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tejun Heo, Bartlomiej Zolnierkiewicz, Geert Uytterhoeven,
linux-ide, linux-kernel
On Mon, Jul 10, 2017 at 10:51 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> We cannot build the new ftide010 code without also building the faraday
> sata bridge driver:
>
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_probe':
> pata_ftide010.c:(.text+0x2b8): undefined reference to `gemini_sata_bridge_get'
> pata_ftide010.c:(.text+0x32c): undefined reference to `gemini_sata_get_muxmode'
> pata_ftide010.c:(.text+0x358): undefined reference to `gemini_sata_bridge_enabled'
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_stop':
> pata_ftide010.c:(.text+0x520): undefined reference to `gemini_sata_stop_bridge'
> drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_start':
> pata_ftide010.c:(.text+0x5bc): undefined reference to `gemini_sata_start_bridge'
>
> This adjusts the Kconfig dependencies accordingly.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
My intention was definately to have the bridge driver as a separate add-on
as I suspect some systems use the PATA driver without the SATA bridge.
But we can definately deal with that when those users appear.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-11 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 8:51 [PATCH] ata: fix gemini Kconfig dependencies Arnd Bergmann
2017-07-10 17:43 ` Tejun Heo
2017-07-11 14:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).