* [PATCH] mfd: ab8500-core: constify attribute_group structures.
@ 2017-07-10 5:37 Arvind Yadav
2017-07-17 14:35 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-10 5:37 UTC (permalink / raw)
To: linus.walleij, lee.jones; +Cc: linux-arm-kernel, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
16298 1009 184 17491 4453 drivers/mfd/ab8500-core.o
File size After adding 'const':
text data bss dec hex filename
16490 817 184 17491 4453 drivers/mfd/ab8500-core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mfd/ab8500-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 8511c06..30d09d1 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -1059,15 +1059,15 @@ static DEVICE_ATTR(dbbrstn, S_IRUGO | S_IWUSR,
NULL,
};
-static struct attribute_group ab8500_attr_group = {
+static const struct attribute_group ab8500_attr_group = {
.attrs = ab8500_sysfs_entries,
};
-static struct attribute_group ab8505_attr_group = {
+static const struct attribute_group ab8505_attr_group = {
.attrs = ab8505_sysfs_entries,
};
-static struct attribute_group ab9540_attr_group = {
+static const struct attribute_group ab9540_attr_group = {
.attrs = ab9540_sysfs_entries,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: ab8500-core: constify attribute_group structures.
2017-07-10 5:37 [PATCH] mfd: ab8500-core: constify attribute_group structures Arvind Yadav
@ 2017-07-17 14:35 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-07-17 14:35 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linus.walleij, linux-arm-kernel, linux-kernel
On Mon, 10 Jul 2017, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 16298 1009 184 17491 4453 drivers/mfd/ab8500-core.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 16490 817 184 17491 4453 drivers/mfd/ab8500-core.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mfd/ab8500-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index 8511c06..30d09d1 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -1059,15 +1059,15 @@ static DEVICE_ATTR(dbbrstn, S_IRUGO | S_IWUSR,
> NULL,
> };
>
> -static struct attribute_group ab8500_attr_group = {
> +static const struct attribute_group ab8500_attr_group = {
> .attrs = ab8500_sysfs_entries,
> };
>
> -static struct attribute_group ab8505_attr_group = {
> +static const struct attribute_group ab8505_attr_group = {
> .attrs = ab8505_sysfs_entries,
> };
>
> -static struct attribute_group ab9540_attr_group = {
> +static const struct attribute_group ab9540_attr_group = {
> .attrs = ab9540_sysfs_entries,
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-17 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 5:37 [PATCH] mfd: ab8500-core: constify attribute_group structures Arvind Yadav
2017-07-17 14:35 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).