[PATCH 1/3] arm64: allwinner: a64: enable USB host controller for BPi M64

[PATCH 1/3] arm64: allwinner: a64: enable USB host controller for BPi M64

[Icenowy Zheng]

Banana Pi M64 connects the USB host-only controller on A64 SoC to a USB
hub, which provided the two USB Type-A ports on the board.

Enable the USB host controller.

The OTG function of the Micro-USB port needs the drivevbus function of
the AXP803 driver implemented, so it's not enabled now.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index 0d1f026d831a..829922d077fb 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -67,6 +67,10 @@
 	};
 };
 
+&ehci1 {
+	status = "okay";
+};
+
 &emac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmii_pins>;
@@ -122,6 +126,10 @@
 	status = "okay";
 };
 
+&ohci1 {
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins_a>;
@@ -133,3 +141,7 @@
 	pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
 	status = "okay";
 };
+
+&usbphy {
+	status = "okay";
+};
-- 
2.13.0

[PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Icenowy Zheng]

Banana Pi M64 board uses an AXP803 PMIC.

Enable the PMIC and its regulators.

As we have now proper regulators support, missing or dummy regulators
are changed to the correct ones.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116 +++++++++++++++++++--
 1 file changed, 106 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index 829922d077fb..51d67c0a0edf 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -58,13 +58,6 @@
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
-
-	reg_vcc3v3: vcc3v3 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc3v3";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-	};
 };
 
 &ehci1 {
@@ -76,6 +69,7 @@
 	pinctrl-0 = <&rgmii_pins>;
 	phy-mode = "rgmii";
 	phy-handle = <&ext_rgmii_phy>;
+	phy-supply = <&reg_dc1sw>;
 	status = "okay";
 };
 
@@ -99,7 +93,7 @@
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
 	cd-inverted;
 	disable-wp;
@@ -110,7 +104,8 @@
 &mmc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dldo2>;
+	vqmmc-supply = <&reg_dldo4>;
 	bus-width = <4>;
 	non-removable;
 	status = "okay";
@@ -119,7 +114,7 @@
 &mmc2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc2_pins>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	bus-width = <8>;
 	non-removable;
 	cap-mmc-hw-reset;
@@ -130,6 +125,107 @@
 	status = "okay";
 };
 
+&r_rsb {
+	status = "okay";
+
+	axp803: pmic@3a3 {
+		compatible = "x-powers,axp803";
+		reg = <0x3a3>;
+		interrupt-parent = <&r_intc>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+#include "axp803.dtsi"
+
+&reg_aldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-pl";
+};
+
+&reg_aldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "vcc-pll-avcc";
+};
+
+&reg_dc1sw {
+	regulator-name = "vcc-phy";
+};
+
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-3v3";
+};
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1300000>;
+	regulator-name = "vdd-cpux";
+};
+
+/* DCDC3 is polyphased with DCDC2 */
+
+&reg_dcdc5 {
+	regulator-always-on;
+	regulator-min-microvolt = <1500000>;
+	regulator-max-microvolt = <1500000>;
+	regulator-name = "vcc-dram";
+};
+
+&reg_dcdc6 {
+	regulator-always-on;
+	regulator-min-microvolt = <1100000>;
+	regulator-max-microvolt = <1100000>;
+	regulator-name = "vdd-sys";
+};
+
+&reg_dldo1 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-hdmi-dsi";
+};
+
+&reg_dldo2 {
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi";
+};
+
+&reg_dldo4 {
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-wifi-io";
+};
+
+&reg_eldo1 {
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <1800000>;
+	regulator-name = "cpvdd";
+};
+
+/*
+ * The A64 chip cannot work without this regulator off, although
+ * it seems to be only driving the AR100 core.
+ * Maybe we don't still know well about CPUs domain.
+ */
+&reg_fldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1100000>;
+	regulator-max-microvolt = <1100000>;
+	regulator-name = "vdd-cpus";
+};
+
+&reg_rtc_ldo {
+	regulator-name = "vcc-rtc";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins_a>;
-- 
2.13.0

[PATCH 3/3] arm64: allwinner: a64: add proper support for the Wi-Fi on BPi M64

[Icenowy Zheng]

BPi M64 has an AP6212 Wi-Fi/Bluetooth combo module, and the Wi-Fi SDIO
card is connected to the mmc1 controller.

The pwrseq of the mmc1 (used to reset the card) used to missing, and the
out-of-band interrupt line of the card is not specified.

Fix these issues for proper Wi-Fi support of BPi M64.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index 51d67c0a0edf..037142231962 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -58,6 +58,11 @@
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
+
+	wifi_pwrseq: wifi_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
+	};
 };
 
 &ehci1 {
@@ -106,9 +111,18 @@
 	pinctrl-0 = <&mmc1_pins>;
 	vmmc-supply = <&reg_dldo2>;
 	vqmmc-supply = <&reg_dldo4>;
+	mmc-pwrseq = <&wifi_pwrseq>;
 	bus-width = <4>;
 	non-removable;
 	status = "okay";
+
+	brcmf: wifi@1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&r_pio>;
+		interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
+		interrupt-names = "host-wake";
+	};
 };
 
 &mmc2 {
-- 
2.13.0

Re: [linux-sunxi] [PATCH 1/3] arm64: allwinner: a64: enable USB host controller for BPi M64

[Chen-Yu Tsai]

On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Banana Pi M64 connects the USB host-only controller on A64 SoC to a USB
> hub, which provided the two USB Type-A ports on the board.
>
> Enable the USB host controller.
>
> The OTG function of the Micro-USB port needs the drivevbus function of
> the AXP803 driver implemented, so it's not enabled now.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Reviewed-by: Chen-Yu Tsai <wens@csie.org>

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Chen-Yu Tsai]

On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> Banana Pi M64 board uses an AXP803 PMIC.
>
> Enable the PMIC and its regulators.
>
> As we have now proper regulators support, missing or dummy regulators
> are changed to the correct ones.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116 +++++++++++++++++++--
>  1 file changed, 106 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index 829922d077fb..51d67c0a0edf 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -58,13 +58,6 @@
>         chosen {
>                 stdout-path = "serial0:115200n8";
>         };
> -
> -       reg_vcc3v3: vcc3v3 {
> -               compatible = "regulator-fixed";
> -               regulator-name = "vcc3v3";
> -               regulator-min-microvolt = <3300000>;
> -               regulator-max-microvolt = <3300000>;
> -       };
>  };
>
>  &ehci1 {
> @@ -76,6 +69,7 @@
>         pinctrl-0 = <&rgmii_pins>;
>         phy-mode = "rgmii";
>         phy-handle = <&ext_rgmii_phy>;
> +       phy-supply = <&reg_dc1sw>;
>         status = "okay";
>  };
>
> @@ -99,7 +93,7 @@
>  &mmc0 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc0_pins>;
> -       vmmc-supply = <&reg_vcc3v3>;
> +       vmmc-supply = <&reg_dcdc1>;
>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>         cd-inverted;
>         disable-wp;
> @@ -110,7 +104,8 @@
>  &mmc1 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc1_pins>;
> -       vmmc-supply = <&reg_vcc3v3>;
> +       vmmc-supply = <&reg_dldo2>;
> +       vqmmc-supply = <&reg_dldo4>;
>         bus-width = <4>;
>         non-removable;
>         status = "okay";
> @@ -119,7 +114,7 @@
>  &mmc2 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
> -       vmmc-supply = <&reg_vcc3v3>;
> +       vmmc-supply = <&reg_dcdc1>;
>         bus-width = <8>;
>         non-removable;
>         cap-mmc-hw-reset;
> @@ -130,6 +125,107 @@
>         status = "okay";
>  };
>
> +&r_rsb {
> +       status = "okay";
> +
> +       axp803: pmic@3a3 {
> +               compatible = "x-powers,axp803";
> +               reg = <0x3a3>;
> +               interrupt-parent = <&r_intc>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +       };
> +};
> +
> +#include "axp803.dtsi"
> +
> +&reg_aldo2 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-pl";
> +};
> +
> +&reg_aldo3 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <3000000>;
> +       regulator-max-microvolt = <3000000>;
> +       regulator-name = "vcc-pll-avcc";
> +};
> +
> +&reg_dc1sw {
> +       regulator-name = "vcc-phy";
> +};
> +
> +&reg_dcdc1 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-3v3";
> +};
> +
> +&reg_dcdc2 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1000000>;

The datasheet says the minimum voltage is 1.04V.

> +       regulator-max-microvolt = <1300000>;
> +       regulator-name = "vdd-cpux";
> +};
> +
> +/* DCDC3 is polyphased with DCDC2 */
> +
> +&reg_dcdc5 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1500000>;
> +       regulator-max-microvolt = <1500000>;
> +       regulator-name = "vcc-dram";
> +};
> +
> +&reg_dcdc6 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1100000>;
> +       regulator-max-microvolt = <1100000>;
> +       regulator-name = "vdd-sys";
> +};
> +
> +&reg_dldo1 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-hdmi-dsi";
> +};
> +
> +&reg_dldo2 {
> +       regulator-min-microvolt = <3300000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-wifi";
> +};
> +
> +&reg_dldo4 {
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <3300000>;
> +       regulator-name = "vcc-wifi-io";
> +};
> +
> +&reg_eldo1 {
> +       regulator-min-microvolt = <1800000>;
> +       regulator-max-microvolt = <1800000>;
> +       regulator-name = "cpvdd";
> +};
> +

It looks like you are missing a few regulators? I assume you
would add them once the peripherals that use them are added?

Otherwise this patch looks good.

ChenYu

> +/*
> + * The A64 chip cannot work without this regulator off, although
> + * it seems to be only driving the AR100 core.
> + * Maybe we don't still know well about CPUs domain.
> + */
> +&reg_fldo2 {
> +       regulator-always-on;
> +       regulator-min-microvolt = <1100000>;
> +       regulator-max-microvolt = <1100000>;
> +       regulator-name = "vdd-cpus";
> +};
> +
> +&reg_rtc_ldo {
> +       regulator-name = "vcc-rtc";
> +};
> +
>  &uart0 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&uart0_pins_a>;
> --
> 2.13.0
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Icenowy Zheng]

于 2017年7月21日 GMT+08:00 下午3:42:07, Chen-Yu Tsai <wens@csie.org> 写到:
>On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> Banana Pi M64 board uses an AXP803 PMIC.
>>
>> Enable the PMIC and its regulators.
>>
>> As we have now proper regulators support, missing or dummy regulators
>> are changed to the correct ones.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116
>+++++++++++++++++++--
>>  1 file changed, 106 insertions(+), 10 deletions(-)
>>
>> diff --git
>a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>> index 829922d077fb..51d67c0a0edf 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>> @@ -58,13 +58,6 @@
>>         chosen {
>>                 stdout-path = "serial0:115200n8";
>>         };
>> -
>> -       reg_vcc3v3: vcc3v3 {
>> -               compatible = "regulator-fixed";
>> -               regulator-name = "vcc3v3";
>> -               regulator-min-microvolt = <3300000>;
>> -               regulator-max-microvolt = <3300000>;
>> -       };
>>  };
>>
>>  &ehci1 {
>> @@ -76,6 +69,7 @@
>>         pinctrl-0 = <&rgmii_pins>;
>>         phy-mode = "rgmii";
>>         phy-handle = <&ext_rgmii_phy>;
>> +       phy-supply = <&reg_dc1sw>;
>>         status = "okay";
>>  };
>>
>> @@ -99,7 +93,7 @@
>>  &mmc0 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc0_pins>;
>> -       vmmc-supply = <&reg_vcc3v3>;
>> +       vmmc-supply = <&reg_dcdc1>;
>>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>         cd-inverted;
>>         disable-wp;
>> @@ -110,7 +104,8 @@
>>  &mmc1 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc1_pins>;
>> -       vmmc-supply = <&reg_vcc3v3>;
>> +       vmmc-supply = <&reg_dldo2>;
>> +       vqmmc-supply = <&reg_dldo4>;
>>         bus-width = <4>;
>>         non-removable;
>>         status = "okay";
>> @@ -119,7 +114,7 @@
>>  &mmc2 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&mmc2_pins>;
>> -       vmmc-supply = <&reg_vcc3v3>;
>> +       vmmc-supply = <&reg_dcdc1>;
>>         bus-width = <8>;
>>         non-removable;
>>         cap-mmc-hw-reset;
>> @@ -130,6 +125,107 @@
>>         status = "okay";
>>  };
>>
>> +&r_rsb {
>> +       status = "okay";
>> +
>> +       axp803: pmic@3a3 {
>> +               compatible = "x-powers,axp803";
>> +               reg = <0x3a3>;
>> +               interrupt-parent = <&r_intc>;
>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> +       };
>> +};
>> +
>> +#include "axp803.dtsi"
>> +
>> +&reg_aldo2 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1800000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-pl";
>> +};
>> +
>> +&reg_aldo3 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <3000000>;
>> +       regulator-max-microvolt = <3000000>;
>> +       regulator-name = "vcc-pll-avcc";
>> +};
>> +
>> +&reg_dc1sw {
>> +       regulator-name = "vcc-phy";
>> +};
>> +
>> +&reg_dcdc1 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-3v3";
>> +};
>> +
>> +&reg_dcdc2 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1000000>;
>
>The datasheet says the minimum voltage is 1.04V.

A64 datasheet?

Maybe I need to fix all A64 AXP patches.

>
>> +       regulator-max-microvolt = <1300000>;
>> +       regulator-name = "vdd-cpux";
>> +};
>> +
>> +/* DCDC3 is polyphased with DCDC2 */
>> +
>> +&reg_dcdc5 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1500000>;
>> +       regulator-max-microvolt = <1500000>;
>> +       regulator-name = "vcc-dram";
>> +};
>> +
>> +&reg_dcdc6 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1100000>;
>> +       regulator-max-microvolt = <1100000>;
>> +       regulator-name = "vdd-sys";
>> +};
>> +
>> +&reg_dldo1 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-hdmi-dsi";
>> +};
>> +
>> +&reg_dldo2 {
>> +       regulator-min-microvolt = <3300000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-wifi";
>> +};
>> +
>> +&reg_dldo4 {
>> +       regulator-min-microvolt = <1800000>;
>> +       regulator-max-microvolt = <3300000>;
>> +       regulator-name = "vcc-wifi-io";
>> +};
>> +
>> +&reg_eldo1 {
>> +       regulator-min-microvolt = <1800000>;
>> +       regulator-max-microvolt = <1800000>;
>> +       regulator-name = "cpvdd";
>> +};
>> +
>
>It looks like you are missing a few regulators? I assume you
>would add them once the peripherals that use them are added?

Yes.

I mainly dropped CSI part, as it seems so complicate.

>
>Otherwise this patch looks good.
>
>ChenYu
>
>> +/*
>> + * The A64 chip cannot work without this regulator off, although
>> + * it seems to be only driving the AR100 core.
>> + * Maybe we don't still know well about CPUs domain.
>> + */
>> +&reg_fldo2 {
>> +       regulator-always-on;
>> +       regulator-min-microvolt = <1100000>;
>> +       regulator-max-microvolt = <1100000>;
>> +       regulator-name = "vdd-cpus";
>> +};
>> +
>> +&reg_rtc_ldo {
>> +       regulator-name = "vcc-rtc";
>> +};
>> +
>>  &uart0 {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&uart0_pins_a>;
>> --
>> 2.13.0
>>
>> --
>> You received this message because you are subscribed to the Google
>Groups "linux-sunxi" group.
>> To unsubscribe from this group and stop receiving emails from it,
>send an email to linux-sunxi+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Chen-Yu Tsai]

On Fri, Jul 21, 2017 at 3:44 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> 于 2017年7月21日 GMT+08:00 下午3:42:07, Chen-Yu Tsai <wens@csie.org> 写到:
>>On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>> Banana Pi M64 board uses an AXP803 PMIC.
>>>
>>> Enable the PMIC and its regulators.
>>>
>>> As we have now proper regulators support, missing or dummy regulators
>>> are changed to the correct ones.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116
>>+++++++++++++++++++--
>>>  1 file changed, 106 insertions(+), 10 deletions(-)
>>>
>>> diff --git
>>a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>> index 829922d077fb..51d67c0a0edf 100644
>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>> @@ -58,13 +58,6 @@
>>>         chosen {
>>>                 stdout-path = "serial0:115200n8";
>>>         };
>>> -
>>> -       reg_vcc3v3: vcc3v3 {
>>> -               compatible = "regulator-fixed";
>>> -               regulator-name = "vcc3v3";
>>> -               regulator-min-microvolt = <3300000>;
>>> -               regulator-max-microvolt = <3300000>;
>>> -       };
>>>  };
>>>
>>>  &ehci1 {
>>> @@ -76,6 +69,7 @@
>>>         pinctrl-0 = <&rgmii_pins>;
>>>         phy-mode = "rgmii";
>>>         phy-handle = <&ext_rgmii_phy>;
>>> +       phy-supply = <&reg_dc1sw>;
>>>         status = "okay";
>>>  };
>>>
>>> @@ -99,7 +93,7 @@
>>>  &mmc0 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&mmc0_pins>;
>>> -       vmmc-supply = <&reg_vcc3v3>;
>>> +       vmmc-supply = <&reg_dcdc1>;
>>>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>>         cd-inverted;
>>>         disable-wp;
>>> @@ -110,7 +104,8 @@
>>>  &mmc1 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&mmc1_pins>;
>>> -       vmmc-supply = <&reg_vcc3v3>;
>>> +       vmmc-supply = <&reg_dldo2>;
>>> +       vqmmc-supply = <&reg_dldo4>;
>>>         bus-width = <4>;
>>>         non-removable;
>>>         status = "okay";
>>> @@ -119,7 +114,7 @@
>>>  &mmc2 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&mmc2_pins>;
>>> -       vmmc-supply = <&reg_vcc3v3>;
>>> +       vmmc-supply = <&reg_dcdc1>;
>>>         bus-width = <8>;
>>>         non-removable;
>>>         cap-mmc-hw-reset;
>>> @@ -130,6 +125,107 @@
>>>         status = "okay";
>>>  };
>>>
>>> +&r_rsb {
>>> +       status = "okay";
>>> +
>>> +       axp803: pmic@3a3 {
>>> +               compatible = "x-powers,axp803";
>>> +               reg = <0x3a3>;
>>> +               interrupt-parent = <&r_intc>;
>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>> +       };
>>> +};
>>> +
>>> +#include "axp803.dtsi"
>>> +
>>> +&reg_aldo2 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1800000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-pl";
>>> +};
>>> +
>>> +&reg_aldo3 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <3000000>;
>>> +       regulator-max-microvolt = <3000000>;
>>> +       regulator-name = "vcc-pll-avcc";
>>> +};
>>> +
>>> +&reg_dc1sw {
>>> +       regulator-name = "vcc-phy";
>>> +};
>>> +
>>> +&reg_dcdc1 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-3v3";
>>> +};
>>> +
>>> +&reg_dcdc2 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1000000>;
>>
>>The datasheet says the minimum voltage is 1.04V.
>
> A64 datasheet?

Yes. V1.1.

>
> Maybe I need to fix all A64 AXP patches.
>
>>
>>> +       regulator-max-microvolt = <1300000>;
>>> +       regulator-name = "vdd-cpux";
>>> +};
>>> +
>>> +/* DCDC3 is polyphased with DCDC2 */
>>> +
>>> +&reg_dcdc5 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1500000>;
>>> +       regulator-max-microvolt = <1500000>;
>>> +       regulator-name = "vcc-dram";
>>> +};
>>> +
>>> +&reg_dcdc6 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1100000>;
>>> +       regulator-max-microvolt = <1100000>;
>>> +       regulator-name = "vdd-sys";
>>> +};
>>> +
>>> +&reg_dldo1 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-hdmi-dsi";
>>> +};
>>> +
>>> +&reg_dldo2 {
>>> +       regulator-min-microvolt = <3300000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-wifi";
>>> +};
>>> +
>>> +&reg_dldo4 {
>>> +       regulator-min-microvolt = <1800000>;
>>> +       regulator-max-microvolt = <3300000>;
>>> +       regulator-name = "vcc-wifi-io";
>>> +};
>>> +
>>> +&reg_eldo1 {
>>> +       regulator-min-microvolt = <1800000>;
>>> +       regulator-max-microvolt = <1800000>;
>>> +       regulator-name = "cpvdd";
>>> +};
>>> +
>>
>>It looks like you are missing a few regulators? I assume you
>>would add them once the peripherals that use them are added?
>
> Yes.
>
> I mainly dropped CSI part, as it seems so complicate.

HSIC is also missing. I know the board doesn't use the feature,
but the regulator is hooked up. It would be better to set the
name and constraints.

ChenYu

>
>>
>>Otherwise this patch looks good.
>>
>>ChenYu
>>
>>> +/*
>>> + * The A64 chip cannot work without this regulator off, although
>>> + * it seems to be only driving the AR100 core.
>>> + * Maybe we don't still know well about CPUs domain.
>>> + */
>>> +&reg_fldo2 {
>>> +       regulator-always-on;
>>> +       regulator-min-microvolt = <1100000>;
>>> +       regulator-max-microvolt = <1100000>;
>>> +       regulator-name = "vdd-cpus";
>>> +};
>>> +
>>> +&reg_rtc_ldo {
>>> +       regulator-name = "vcc-rtc";
>>> +};
>>> +
>>>  &uart0 {
>>>         pinctrl-names = "default";
>>>         pinctrl-0 = <&uart0_pins_a>;
>>> --
>>> 2.13.0
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>Groups "linux-sunxi" group.
>>> To unsubscribe from this group and stop receiving emails from it,
>>send an email to linux-sunxi+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[icenowy]

在 2017-07-21 15:49，Chen-Yu Tsai 写道：
> On Fri, Jul 21, 2017 at 3:44 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>> 
>> 
>> 于 2017年7月21日 GMT+08:00 下午3:42:07, Chen-Yu Tsai <wens@csie.org> 写到:
>>> On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> 
>>> wrote:
>>>> Banana Pi M64 board uses an AXP803 PMIC.
>>>> 
>>>> Enable the PMIC and its regulators.
>>>> 
>>>> As we have now proper regulators support, missing or dummy 
>>>> regulators
>>>> are changed to the correct ones.
>>>> 
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>> ---
>>>>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116
>>> +++++++++++++++++++--
>>>>  1 file changed, 106 insertions(+), 10 deletions(-)
>>>> 
>>>> diff --git
>>> a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>> index 829922d077fb..51d67c0a0edf 100644
>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>> @@ -58,13 +58,6 @@
>>>>         chosen {
>>>>                 stdout-path = "serial0:115200n8";
>>>>         };
>>>> -
>>>> -       reg_vcc3v3: vcc3v3 {
>>>> -               compatible = "regulator-fixed";
>>>> -               regulator-name = "vcc3v3";
>>>> -               regulator-min-microvolt = <3300000>;
>>>> -               regulator-max-microvolt = <3300000>;
>>>> -       };
>>>>  };
>>>> 
>>>>  &ehci1 {
>>>> @@ -76,6 +69,7 @@
>>>>         pinctrl-0 = <&rgmii_pins>;
>>>>         phy-mode = "rgmii";
>>>>         phy-handle = <&ext_rgmii_phy>;
>>>> +       phy-supply = <&reg_dc1sw>;
>>>>         status = "okay";
>>>>  };
>>>> 
>>>> @@ -99,7 +93,7 @@
>>>>  &mmc0 {
>>>>         pinctrl-names = "default";
>>>>         pinctrl-0 = <&mmc0_pins>;
>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>>>         cd-inverted;
>>>>         disable-wp;
>>>> @@ -110,7 +104,8 @@
>>>>  &mmc1 {
>>>>         pinctrl-names = "default";
>>>>         pinctrl-0 = <&mmc1_pins>;
>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>> +       vmmc-supply = <&reg_dldo2>;
>>>> +       vqmmc-supply = <&reg_dldo4>;
>>>>         bus-width = <4>;
>>>>         non-removable;
>>>>         status = "okay";
>>>> @@ -119,7 +114,7 @@
>>>>  &mmc2 {
>>>>         pinctrl-names = "default";
>>>>         pinctrl-0 = <&mmc2_pins>;
>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>         bus-width = <8>;
>>>>         non-removable;
>>>>         cap-mmc-hw-reset;
>>>> @@ -130,6 +125,107 @@
>>>>         status = "okay";
>>>>  };
>>>> 
>>>> +&r_rsb {
>>>> +       status = "okay";
>>>> +
>>>> +       axp803: pmic@3a3 {
>>>> +               compatible = "x-powers,axp803";
>>>> +               reg = <0x3a3>;
>>>> +               interrupt-parent = <&r_intc>;
>>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>>> +       };
>>>> +};
>>>> +
>>>> +#include "axp803.dtsi"
>>>> +
>>>> +&reg_aldo2 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1800000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-pl";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <3000000>;
>>>> +       regulator-max-microvolt = <3000000>;
>>>> +       regulator-name = "vcc-pll-avcc";
>>>> +};
>>>> +
>>>> +&reg_dc1sw {
>>>> +       regulator-name = "vcc-phy";
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1000000>;
>>> 
>>> The datasheet says the minimum voltage is 1.04V.
>> 
>> A64 datasheet?
> 
> Yes. V1.1.
> 
>> 
>> Maybe I need to fix all A64 AXP patches.
>> 
>>> 
>>>> +       regulator-max-microvolt = <1300000>;
>>>> +       regulator-name = "vdd-cpux";
>>>> +};
>>>> +
>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>> +
>>>> +&reg_dcdc5 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1500000>;
>>>> +       regulator-max-microvolt = <1500000>;
>>>> +       regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dcdc6 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1100000>;
>>>> +       regulator-max-microvolt = <1100000>;
>>>> +       regulator-name = "vdd-sys";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-hdmi-dsi";
>>>> +};
>>>> +
>>>> +&reg_dldo2 {
>>>> +       regulator-min-microvolt = <3300000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> +       regulator-min-microvolt = <1800000>;
>>>> +       regulator-max-microvolt = <3300000>;
>>>> +       regulator-name = "vcc-wifi-io";
>>>> +};
>>>> +
>>>> +&reg_eldo1 {
>>>> +       regulator-min-microvolt = <1800000>;
>>>> +       regulator-max-microvolt = <1800000>;
>>>> +       regulator-name = "cpvdd";
>>>> +};
>>>> +
>>> 
>>> It looks like you are missing a few regulators? I assume you
>>> would add them once the peripherals that use them are added?
>> 
>> Yes.
>> 
>> I mainly dropped CSI part, as it seems so complicate.
> 
> HSIC is also missing. I know the board doesn't use the feature,
> but the regulator is hooked up. It would be better to set the
> name and constraints.

OK.

I think maybe Pine64 and SoPine w/ baseborad also need the HSIC
regulator set up, right? (They're also not used but hooked)

> 
> ChenYu
> 
>> 
>>> 
>>> Otherwise this patch looks good.
>>> 
>>> ChenYu
>>> 
>>>> +/*
>>>> + * The A64 chip cannot work without this regulator off, although
>>>> + * it seems to be only driving the AR100 core.
>>>> + * Maybe we don't still know well about CPUs domain.
>>>> + */
>>>> +&reg_fldo2 {
>>>> +       regulator-always-on;
>>>> +       regulator-min-microvolt = <1100000>;
>>>> +       regulator-max-microvolt = <1100000>;
>>>> +       regulator-name = "vdd-cpus";
>>>> +};
>>>> +
>>>> +&reg_rtc_ldo {
>>>> +       regulator-name = "vcc-rtc";
>>>> +};
>>>> +
>>>>  &uart0 {
>>>>         pinctrl-names = "default";
>>>>         pinctrl-0 = <&uart0_pins_a>;
>>>> --
>>>> 2.13.0
>>>> 
>>>> --
>>>> You received this message because you are subscribed to the Google
>>> Groups "linux-sunxi" group.
>>>> To unsubscribe from this group and stop receiving emails from it,
>>> send an email to linux-sunxi+unsubscribe@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>> 
>> --
>> You received this message because you are subscribed to the Google 
>> Groups "linux-sunxi" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to linux-sunxi+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Chen-Yu Tsai]

On Fri, Jul 21, 2017 at 7:38 PM,  <icenowy@aosc.io> wrote:
> 在 2017-07-21 15:49，Chen-Yu Tsai 写道：
>>
>> On Fri, Jul 21, 2017 at 3:44 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>>
>>>
>>>
>>> 于 2017年7月21日 GMT+08:00 下午3:42:07, Chen-Yu Tsai <wens@csie.org> 写到:
>>>>
>>>> On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>>>>
>>>>> Banana Pi M64 board uses an AXP803 PMIC.
>>>>>
>>>>> Enable the PMIC and its regulators.
>>>>>
>>>>> As we have now proper regulators support, missing or dummy regulators
>>>>> are changed to the correct ones.
>>>>>
>>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>>> ---
>>>>>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116
>>>>
>>>> +++++++++++++++++++--
>>>>>
>>>>>  1 file changed, 106 insertions(+), 10 deletions(-)
>>>>>
>>>>> diff --git
>>>>
>>>> a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>>
>>>>> index 829922d077fb..51d67c0a0edf 100644
>>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>> @@ -58,13 +58,6 @@
>>>>>         chosen {
>>>>>                 stdout-path = "serial0:115200n8";
>>>>>         };
>>>>> -
>>>>> -       reg_vcc3v3: vcc3v3 {
>>>>> -               compatible = "regulator-fixed";
>>>>> -               regulator-name = "vcc3v3";
>>>>> -               regulator-min-microvolt = <3300000>;
>>>>> -               regulator-max-microvolt = <3300000>;
>>>>> -       };
>>>>>  };
>>>>>
>>>>>  &ehci1 {
>>>>> @@ -76,6 +69,7 @@
>>>>>         pinctrl-0 = <&rgmii_pins>;
>>>>>         phy-mode = "rgmii";
>>>>>         phy-handle = <&ext_rgmii_phy>;
>>>>> +       phy-supply = <&reg_dc1sw>;
>>>>>         status = "okay";
>>>>>  };
>>>>>
>>>>> @@ -99,7 +93,7 @@
>>>>>  &mmc0 {
>>>>>         pinctrl-names = "default";
>>>>>         pinctrl-0 = <&mmc0_pins>;
>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>>>>         cd-inverted;
>>>>>         disable-wp;
>>>>> @@ -110,7 +104,8 @@
>>>>>  &mmc1 {
>>>>>         pinctrl-names = "default";
>>>>>         pinctrl-0 = <&mmc1_pins>;
>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>> +       vmmc-supply = <&reg_dldo2>;
>>>>> +       vqmmc-supply = <&reg_dldo4>;
>>>>>         bus-width = <4>;
>>>>>         non-removable;
>>>>>         status = "okay";
>>>>> @@ -119,7 +114,7 @@
>>>>>  &mmc2 {
>>>>>         pinctrl-names = "default";
>>>>>         pinctrl-0 = <&mmc2_pins>;
>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>>         bus-width = <8>;
>>>>>         non-removable;
>>>>>         cap-mmc-hw-reset;
>>>>> @@ -130,6 +125,107 @@
>>>>>         status = "okay";
>>>>>  };
>>>>>
>>>>> +&r_rsb {
>>>>> +       status = "okay";
>>>>> +
>>>>> +       axp803: pmic@3a3 {
>>>>> +               compatible = "x-powers,axp803";
>>>>> +               reg = <0x3a3>;
>>>>> +               interrupt-parent = <&r_intc>;
>>>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>>>> +       };
>>>>> +};
>>>>> +
>>>>> +#include "axp803.dtsi"
>>>>> +
>>>>> +&reg_aldo2 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <1800000>;
>>>>> +       regulator-max-microvolt = <3300000>;
>>>>> +       regulator-name = "vcc-pl";
>>>>> +};
>>>>> +
>>>>> +&reg_aldo3 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <3000000>;
>>>>> +       regulator-max-microvolt = <3000000>;
>>>>> +       regulator-name = "vcc-pll-avcc";
>>>>> +};
>>>>> +
>>>>> +&reg_dc1sw {
>>>>> +       regulator-name = "vcc-phy";
>>>>> +};
>>>>> +
>>>>> +&reg_dcdc1 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <3300000>;
>>>>> +       regulator-max-microvolt = <3300000>;
>>>>> +       regulator-name = "vcc-3v3";
>>>>> +};
>>>>> +
>>>>> +&reg_dcdc2 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <1000000>;
>>>>
>>>>
>>>> The datasheet says the minimum voltage is 1.04V.
>>>
>>>
>>> A64 datasheet?
>>
>>
>> Yes. V1.1.
>>
>>>
>>> Maybe I need to fix all A64 AXP patches.
>>>
>>>>
>>>>> +       regulator-max-microvolt = <1300000>;
>>>>> +       regulator-name = "vdd-cpux";
>>>>> +};
>>>>> +
>>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>>> +
>>>>> +&reg_dcdc5 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <1500000>;
>>>>> +       regulator-max-microvolt = <1500000>;
>>>>> +       regulator-name = "vcc-dram";
>>>>> +};
>>>>> +
>>>>> +&reg_dcdc6 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <1100000>;
>>>>> +       regulator-max-microvolt = <1100000>;
>>>>> +       regulator-name = "vdd-sys";
>>>>> +};
>>>>> +
>>>>> +&reg_dldo1 {
>>>>> +       regulator-min-microvolt = <3300000>;
>>>>> +       regulator-max-microvolt = <3300000>;
>>>>> +       regulator-name = "vcc-hdmi-dsi";
>>>>> +};
>>>>> +
>>>>> +&reg_dldo2 {
>>>>> +       regulator-min-microvolt = <3300000>;
>>>>> +       regulator-max-microvolt = <3300000>;
>>>>> +       regulator-name = "vcc-wifi";
>>>>> +};
>>>>> +
>>>>> +&reg_dldo4 {
>>>>> +       regulator-min-microvolt = <1800000>;
>>>>> +       regulator-max-microvolt = <3300000>;
>>>>> +       regulator-name = "vcc-wifi-io";
>>>>> +};
>>>>> +
>>>>> +&reg_eldo1 {
>>>>> +       regulator-min-microvolt = <1800000>;
>>>>> +       regulator-max-microvolt = <1800000>;
>>>>> +       regulator-name = "cpvdd";
>>>>> +};
>>>>> +
>>>>
>>>>
>>>> It looks like you are missing a few regulators? I assume you
>>>> would add them once the peripherals that use them are added?
>>>
>>>
>>> Yes.
>>>
>>> I mainly dropped CSI part, as it seems so complicate.
>>
>>
>> HSIC is also missing. I know the board doesn't use the feature,
>> but the regulator is hooked up. It would be better to set the
>> name and constraints.
>
>
> OK.
>
> I think maybe Pine64 and SoPine w/ baseborad also need the HSIC
> regulator set up, right? (They're also not used but hooked)
>

Correct. If they are wired up, then they have constraints that
need to be adhered to.

ChenYu

>>
>> ChenYu
>>
>>>
>>>>
>>>> Otherwise this patch looks good.
>>>>
>>>> ChenYu
>>>>
>>>>> +/*
>>>>> + * The A64 chip cannot work without this regulator off, although
>>>>> + * it seems to be only driving the AR100 core.
>>>>> + * Maybe we don't still know well about CPUs domain.
>>>>> + */
>>>>> +&reg_fldo2 {
>>>>> +       regulator-always-on;
>>>>> +       regulator-min-microvolt = <1100000>;
>>>>> +       regulator-max-microvolt = <1100000>;
>>>>> +       regulator-name = "vdd-cpus";
>>>>> +};
>>>>> +
>>>>> +&reg_rtc_ldo {
>>>>> +       regulator-name = "vcc-rtc";
>>>>> +};
>>>>> +
>>>>>  &uart0 {
>>>>>         pinctrl-names = "default";
>>>>>         pinctrl-0 = <&uart0_pins_a>;
>>>>> --
>>>>> 2.13.0
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>
>>>> Groups "linux-sunxi" group.
>>>>>
>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>
>>>> send an email to linux-sunxi+unsubscribe@googlegroups.com.
>>>>>
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "linux-sunxi" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to linux-sunxi+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: a64: enable AXP803 for Banana Pi M64

[Icenowy Zheng]

于 2017年7月23日 GMT+08:00 下午11:15:04, Chen-Yu Tsai <wens@csie.org> 写到:
>On Fri, Jul 21, 2017 at 7:38 PM,  <icenowy@aosc.io> wrote:
>> 在 2017-07-21 15:49，Chen-Yu Tsai 写道：
>>>
>>> On Fri, Jul 21, 2017 at 3:44 PM, Icenowy Zheng <icenowy@aosc.io>
>wrote:
>>>>
>>>>
>>>>
>>>> 于 2017年7月21日 GMT+08:00 下午3:42:07, Chen-Yu Tsai <wens@csie.org> 写到:
>>>>>
>>>>> On Fri, Jul 21, 2017 at 7:07 AM, Icenowy Zheng <icenowy@aosc.io>
>wrote:
>>>>>>
>>>>>> Banana Pi M64 board uses an AXP803 PMIC.
>>>>>>
>>>>>> Enable the PMIC and its regulators.
>>>>>>
>>>>>> As we have now proper regulators support, missing or dummy
>regulators
>>>>>> are changed to the correct ones.
>>>>>>
>>>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>>>> ---
>>>>>>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 116
>>>>>
>>>>> +++++++++++++++++++--
>>>>>>
>>>>>>  1 file changed, 106 insertions(+), 10 deletions(-)
>>>>>>
>>>>>> diff --git
>>>>>
>>>>> a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>>>
>>>>>> index 829922d077fb..51d67c0a0edf 100644
>>>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
>>>>>> @@ -58,13 +58,6 @@
>>>>>>         chosen {
>>>>>>                 stdout-path = "serial0:115200n8";
>>>>>>         };
>>>>>> -
>>>>>> -       reg_vcc3v3: vcc3v3 {
>>>>>> -               compatible = "regulator-fixed";
>>>>>> -               regulator-name = "vcc3v3";
>>>>>> -               regulator-min-microvolt = <3300000>;
>>>>>> -               regulator-max-microvolt = <3300000>;
>>>>>> -       };
>>>>>>  };
>>>>>>
>>>>>>  &ehci1 {
>>>>>> @@ -76,6 +69,7 @@
>>>>>>         pinctrl-0 = <&rgmii_pins>;
>>>>>>         phy-mode = "rgmii";
>>>>>>         phy-handle = <&ext_rgmii_phy>;
>>>>>> +       phy-supply = <&reg_dc1sw>;
>>>>>>         status = "okay";
>>>>>>  };
>>>>>>
>>>>>> @@ -99,7 +93,7 @@
>>>>>>  &mmc0 {
>>>>>>         pinctrl-names = "default";
>>>>>>         pinctrl-0 = <&mmc0_pins>;
>>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>>>         cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>>>>>         cd-inverted;
>>>>>>         disable-wp;
>>>>>> @@ -110,7 +104,8 @@
>>>>>>  &mmc1 {
>>>>>>         pinctrl-names = "default";
>>>>>>         pinctrl-0 = <&mmc1_pins>;
>>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>>> +       vmmc-supply = <&reg_dldo2>;
>>>>>> +       vqmmc-supply = <&reg_dldo4>;
>>>>>>         bus-width = <4>;
>>>>>>         non-removable;
>>>>>>         status = "okay";
>>>>>> @@ -119,7 +114,7 @@
>>>>>>  &mmc2 {
>>>>>>         pinctrl-names = "default";
>>>>>>         pinctrl-0 = <&mmc2_pins>;
>>>>>> -       vmmc-supply = <&reg_vcc3v3>;
>>>>>> +       vmmc-supply = <&reg_dcdc1>;
>>>>>>         bus-width = <8>;
>>>>>>         non-removable;
>>>>>>         cap-mmc-hw-reset;
>>>>>> @@ -130,6 +125,107 @@
>>>>>>         status = "okay";
>>>>>>  };
>>>>>>
>>>>>> +&r_rsb {
>>>>>> +       status = "okay";
>>>>>> +
>>>>>> +       axp803: pmic@3a3 {
>>>>>> +               compatible = "x-powers,axp803";
>>>>>> +               reg = <0x3a3>;
>>>>>> +               interrupt-parent = <&r_intc>;
>>>>>> +               interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>>>>>> +       };
>>>>>> +};
>>>>>> +
>>>>>> +#include "axp803.dtsi"
>>>>>> +
>>>>>> +&reg_aldo2 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <1800000>;
>>>>>> +       regulator-max-microvolt = <3300000>;
>>>>>> +       regulator-name = "vcc-pl";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_aldo3 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <3000000>;
>>>>>> +       regulator-max-microvolt = <3000000>;
>>>>>> +       regulator-name = "vcc-pll-avcc";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dc1sw {
>>>>>> +       regulator-name = "vcc-phy";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dcdc1 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <3300000>;
>>>>>> +       regulator-max-microvolt = <3300000>;
>>>>>> +       regulator-name = "vcc-3v3";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dcdc2 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <1000000>;
>>>>>
>>>>>
>>>>> The datasheet says the minimum voltage is 1.04V.
>>>>
>>>>
>>>> A64 datasheet?
>>>
>>>
>>> Yes. V1.1.
>>>
>>>>
>>>> Maybe I need to fix all A64 AXP patches.
>>>>
>>>>>
>>>>>> +       regulator-max-microvolt = <1300000>;
>>>>>> +       regulator-name = "vdd-cpux";
>>>>>> +};
>>>>>> +
>>>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>>>> +
>>>>>> +&reg_dcdc5 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <1500000>;
>>>>>> +       regulator-max-microvolt = <1500000>;
>>>>>> +       regulator-name = "vcc-dram";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dcdc6 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <1100000>;
>>>>>> +       regulator-max-microvolt = <1100000>;
>>>>>> +       regulator-name = "vdd-sys";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dldo1 {
>>>>>> +       regulator-min-microvolt = <3300000>;
>>>>>> +       regulator-max-microvolt = <3300000>;
>>>>>> +       regulator-name = "vcc-hdmi-dsi";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dldo2 {
>>>>>> +       regulator-min-microvolt = <3300000>;
>>>>>> +       regulator-max-microvolt = <3300000>;
>>>>>> +       regulator-name = "vcc-wifi";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_dldo4 {
>>>>>> +       regulator-min-microvolt = <1800000>;
>>>>>> +       regulator-max-microvolt = <3300000>;
>>>>>> +       regulator-name = "vcc-wifi-io";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_eldo1 {
>>>>>> +       regulator-min-microvolt = <1800000>;
>>>>>> +       regulator-max-microvolt = <1800000>;
>>>>>> +       regulator-name = "cpvdd";
>>>>>> +};
>>>>>> +
>>>>>
>>>>>
>>>>> It looks like you are missing a few regulators? I assume you
>>>>> would add them once the peripherals that use them are added?
>>>>
>>>>
>>>> Yes.
>>>>
>>>> I mainly dropped CSI part, as it seems so complicate.
>>>
>>>
>>> HSIC is also missing. I know the board doesn't use the feature,
>>> but the regulator is hooked up. It would be better to set the
>>> name and constraints.
>>
>>
>> OK.
>>
>> I think maybe Pine64 and SoPine w/ baseborad also need the HSIC
>> regulator set up, right? (They're also not used but hooked)
>>
>
>Correct. If they are wired up, then they have constraints that
>need to be adhered to.

Already fixed up in Pine64/SoPine patchset v2.

>
>ChenYu
>
>>>
>>> ChenYu
>>>
>>>>
>>>>>
>>>>> Otherwise this patch looks good.
>>>>>
>>>>> ChenYu
>>>>>
>>>>>> +/*
>>>>>> + * The A64 chip cannot work without this regulator off, although
>>>>>> + * it seems to be only driving the AR100 core.
>>>>>> + * Maybe we don't still know well about CPUs domain.
>>>>>> + */
>>>>>> +&reg_fldo2 {
>>>>>> +       regulator-always-on;
>>>>>> +       regulator-min-microvolt = <1100000>;
>>>>>> +       regulator-max-microvolt = <1100000>;
>>>>>> +       regulator-name = "vdd-cpus";
>>>>>> +};
>>>>>> +
>>>>>> +&reg_rtc_ldo {
>>>>>> +       regulator-name = "vcc-rtc";
>>>>>> +};
>>>>>> +
>>>>>>  &uart0 {
>>>>>>         pinctrl-names = "default";
>>>>>>         pinctrl-0 = <&uart0_pins_a>;
>>>>>> --
>>>>>> 2.13.0
>>>>>>
>>>>>> --
>>>>>> You received this message because you are subscribed to the
>Google
>>>>>
>>>>> Groups "linux-sunxi" group.
>>>>>>
>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>
>>>>> send an email to linux-sunxi+unsubscribe@googlegroups.com.
>>>>>>
>>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>Groups
>>>> "linux-sunxi" group.
>>>> To unsubscribe from this group and stop receiving emails from it,
>send an
>>>> email to linux-sunxi+unsubscribe@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>>
>> --
>> You received this message because you are subscribed to the Google
>Groups
>> "linux-sunxi" group.
>> To unsubscribe from this group and stop receiving emails from it,
>send an
>> email to linux-sunxi+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel