linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] staging: pi433: - style fix, space at start of line
@ 2017-07-22  3:51 Derek Robson
  2017-07-22  8:39 ` Marcus Wolf
  2017-07-24  7:53 ` Dan Carpenter
  0 siblings, 2 replies; 3+ messages in thread
From: Derek Robson @ 2017-07-22  3:51 UTC (permalink / raw)
  To: gregkh, robsonde, linux; +Cc: devel, linux-kernel

Fixed checkpatch errors of "please, no spaces at the start of a line"

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/pi433/rf69.c      |   4 +-
 drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
 2 files changed, 105 insertions(+), 105 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index d931437f0b6a..f450bbf3fbbc 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
 	// check value for mantisse and exponent
 	if (exponent > 7)   INVALID_PARAM;
 	if ( (mantisse!=mantisse16) &&
-	     (mantisse!=mantisse20) &&
-             (mantisse!=mantisse24) ) INVALID_PARAM;
+		(mantisse!=mantisse20) &&
+		(mantisse!=mantisse24) ) INVALID_PARAM;
 
 	// read old value
 	newValue = READ_REG(reg);
diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
index fbfb59bd3f3d..635629415e63 100644
--- a/drivers/staging/pi433/rf69_enum.h
+++ b/drivers/staging/pi433/rf69_enum.h
@@ -20,181 +20,181 @@
 
 enum optionOnOff
 {
-    optionOff,
-    optionOn
+	optionOff,
+	optionOn
 };
 
 enum mode
 {
-    mode_sleep,
-    standby,
-    synthesizer,
-    transmit,
-    receive
+	mode_sleep,
+	standby,
+	synthesizer,
+	transmit,
+	receive
 };
 
 enum dataMode
 {
-    packet,
-    continuous,
-    continuousNoSync
+	packet,
+	continuous,
+	continuousNoSync
 };
 
 enum modulation
 {
-    OOK,
-    FSK
+	OOK,
+	FSK
 };
 
 enum modShaping
 {
-    shapingOff,
-    shaping1_0,
-    shaping0_5,
-    shaping0_3,
-    shapingBR,
-    shaping2BR
+	shapingOff,
+	shaping1_0,
+	shaping0_5,
+	shaping0_3,
+	shapingBR,
+	shaping2BR
 };
 
 enum paRamp
 {
-    ramp3400,
-    ramp2000,
-    ramp1000,
-    ramp500,
-    ramp250,
-    ramp125,
-    ramp100,
-    ramp62,
-    ramp50,
-    ramp40,
-    ramp31,
-    ramp25,
-    ramp20,
-    ramp15,
-    ramp12,
-    ramp10
+	ramp3400,
+	ramp2000,
+	ramp1000,
+	ramp500,
+	ramp250,
+	ramp125,
+	ramp100,
+	ramp62,
+	ramp50,
+	ramp40,
+	ramp31,
+	ramp25,
+	ramp20,
+	ramp15,
+	ramp12,
+	ramp10
 };
 
 enum antennaImpedance
 {
-    fiftyOhm,
-    twohundretOhm
+	fiftyOhm,
+	twohundretOhm
 };
 
 enum lnaGain
 {
-    automatic,
-    max,
-    maxMinus6,
-    maxMinus12,
-    maxMinus24,
-    maxMinus36,
-    maxMinus48,
-    undefined
+	automatic,
+	max,
+	maxMinus6,
+	maxMinus12,
+	maxMinus24,
+	maxMinus36,
+	maxMinus48,
+	undefined
 };
 
 enum dccPercent
 {
-    dcc16Percent,
-    dcc8Percent,
-    dcc4Percent,
-    dcc2Percent,
-    dcc1Percent,
-    dcc0_5Percent,
-    dcc0_25Percent,
-    dcc0_125Percent
+	dcc16Percent,
+	dcc8Percent,
+	dcc4Percent,
+	dcc2Percent,
+	dcc1Percent,
+	dcc0_5Percent,
+	dcc0_25Percent,
+	dcc0_125Percent
 };
 
 enum mantisse
 {
-    mantisse16,
-    mantisse20,
-    mantisse24
+	mantisse16,
+	mantisse20,
+	mantisse24
 };
 
 enum thresholdType
 {
-    fixed,
-    peak,
-    average
+	fixed,
+	peak,
+	average
 };
 
 enum thresholdStep
 {
-    step_0_5db,
-    step_1_0db,
-    step_1_5db,
-    step_2_0db,
-    step_3_0db,
-    step_4_0db,
-    step_5_0db,
-    step_6_0db
+	step_0_5db,
+	step_1_0db,
+	step_1_5db,
+	step_2_0db,
+	step_3_0db,
+	step_4_0db,
+	step_5_0db,
+	step_6_0db
 };
 
 enum thresholdDecrement
 {
-    dec_every8th,
-    dec_every4th,
-    dec_every2nd,
-    dec_once,
-    dec_twice,
-    dec_4times,
-    dec_8times,
-    dec_16times
+	dec_every8th,
+	dec_every4th,
+	dec_every2nd,
+	dec_once,
+	dec_twice,
+	dec_4times,
+	dec_8times,
+	dec_16times
 };
 
 enum flag
 {
-    modeSwitchCompleted,
-    readyToReceive,
-    readyToSend,
-    pllLocked,
-    rssiExceededThreshold,
-    timeout,
-    automode,
-    syncAddressMatch,
-    fifoFull,
-//    fifoNotEmpty, collision with next enum; replaced by following enum...
-    fifoEmpty,
-    fifoLevelBelowThreshold,
-    fifoOverrun,
-    packetSent,
-    payloadReady,
-    crcOk,
-    batteryLow
+	modeSwitchCompleted,
+	readyToReceive,
+	readyToSend,
+	pllLocked,
+	rssiExceededThreshold,
+	timeout,
+	automode,
+	syncAddressMatch,
+	fifoFull,
+	// fifoNotEmpty, collision with next enum; replaced by following enum...
+	fifoEmpty,
+	fifoLevelBelowThreshold,
+	fifoOverrun,
+	packetSent,
+	payloadReady,
+	crcOk,
+	batteryLow
 };
 
 enum fifoFillCondition
 {
-    afterSyncInterrupt,
-    always
+	afterSyncInterrupt,
+	always
 };
 
 enum packetFormat
 {
-    packetLengthFix,
-    packetLengthVar
+	packetLengthFix,
+	packetLengthVar
 };
 
 enum txStartCondition
 {
-    fifoLevel,
-    fifoNotEmpty
+	fifoLevel,
+	fifoNotEmpty
 };
 
 enum addressFiltering
 {
-    filteringOff,
-    nodeAddress,
-    nodeOrBroadcastAddress
+	filteringOff,
+	nodeAddress,
+	nodeOrBroadcastAddress
 };
 
 enum dagc
 {
-    normalMode,
-    improve,
-    improve4LowModulationIndex
+	normalMode,
+	improve,
+	improve4LowModulationIndex
 };
 
 
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line
  2017-07-22  3:51 [PATCH 3/3] staging: pi433: - style fix, space at start of line Derek Robson
@ 2017-07-22  8:39 ` Marcus Wolf
  2017-07-24  7:53 ` Dan Carpenter
  1 sibling, 0 replies; 3+ messages in thread
From: Marcus Wolf @ 2017-07-22  8:39 UTC (permalink / raw)
  To: gregkh, Derek Robson; +Cc: linux-kernel, devel

Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>
 
Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all
'm' as a column below each other, all 'a' below each other, ...). For me that
improves the readability a lot. Maybe that can be acchieved somehow without
breaking the style rules - but for sure, that's just luxury :-)

Thanks to Derk for his routine piece of work :-)

Marcus
 

> Derek Robson <robsonde@gmail.com> hat am 22. Juli 2017 um 05:51 geschrieben:
>
>
> Fixed checkpatch errors of "please, no spaces at the start of a line"
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 4 +-
> drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
> 2 files changed, 105 insertions(+), 105 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index d931437f0b6a..f450bbf3fbbc 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8
> reg, enum mantisse mant
> // check value for mantisse and exponent
> if (exponent > 7) INVALID_PARAM;
> if ( (mantisse!=mantisse16) &&
> - (mantisse!=mantisse20) &&
> - (mantisse!=mantisse24) ) INVALID_PARAM;
> + (mantisse!=mantisse20) &&
> + (mantisse!=mantisse24) ) INVALID_PARAM;
>
> // read old value
> newValue = READ_REG(reg);
> diff --git a/drivers/staging/pi433/rf69_enum.h
> b/drivers/staging/pi433/rf69_enum.h
> index fbfb59bd3f3d..635629415e63 100644
> --- a/drivers/staging/pi433/rf69_enum.h
> +++ b/drivers/staging/pi433/rf69_enum.h
> @@ -20,181 +20,181 @@
>
> enum optionOnOff
> {
> - optionOff,
> - optionOn
> + optionOff,
> + optionOn
> };
>
> enum mode
> {
> - mode_sleep,
> - standby,
> - synthesizer,
> - transmit,
> - receive
> + mode_sleep,
> + standby,
> + synthesizer,
> + transmit,
> + receive
> };
>
> enum dataMode
> {
> - packet,
> - continuous,
> - continuousNoSync
> + packet,
> + continuous,
> + continuousNoSync
> };
>
> enum modulation
> {
> - OOK,
> - FSK
> + OOK,
> + FSK
> };
>
> enum modShaping
> {
> - shapingOff,
> - shaping1_0,
> - shaping0_5,
> - shaping0_3,
> - shapingBR,
> - shaping2BR
> + shapingOff,
> + shaping1_0,
> + shaping0_5,
> + shaping0_3,
> + shapingBR,
> + shaping2BR
> };
>
> enum paRamp
> {
> - ramp3400,
> - ramp2000,
> - ramp1000,
> - ramp500,
> - ramp250,
> - ramp125,
> - ramp100,
> - ramp62,
> - ramp50,
> - ramp40,
> - ramp31,
> - ramp25,
> - ramp20,
> - ramp15,
> - ramp12,
> - ramp10
> + ramp3400,
> + ramp2000,
> + ramp1000,
> + ramp500,
> + ramp250,
> + ramp125,
> + ramp100,
> + ramp62,
> + ramp50,
> + ramp40,
> + ramp31,
> + ramp25,
> + ramp20,
> + ramp15,
> + ramp12,
> + ramp10
> };
>
> enum antennaImpedance
> {
> - fiftyOhm,
> - twohundretOhm
> + fiftyOhm,
> + twohundretOhm
> };
>
> enum lnaGain
> {
> - automatic,
> - max,
> - maxMinus6,
> - maxMinus12,
> - maxMinus24,
> - maxMinus36,
> - maxMinus48,
> - undefined
> + automatic,
> + max,
> + maxMinus6,
> + maxMinus12,
> + maxMinus24,
> + maxMinus36,
> + maxMinus48,
> + undefined
> };
>
> enum dccPercent
> {
> - dcc16Percent,
> - dcc8Percent,
> - dcc4Percent,
> - dcc2Percent,
> - dcc1Percent,
> - dcc0_5Percent,
> - dcc0_25Percent,
> - dcc0_125Percent
> + dcc16Percent,
> + dcc8Percent,
> + dcc4Percent,
> + dcc2Percent,
> + dcc1Percent,
> + dcc0_5Percent,
> + dcc0_25Percent,
> + dcc0_125Percent
> };
>
> enum mantisse
> {
> - mantisse16,
> - mantisse20,
> - mantisse24
> + mantisse16,
> + mantisse20,
> + mantisse24
> };
>
> enum thresholdType
> {
> - fixed,
> - peak,
> - average
> + fixed,
> + peak,
> + average
> };
>
> enum thresholdStep
> {
> - step_0_5db,
> - step_1_0db,
> - step_1_5db,
> - step_2_0db,
> - step_3_0db,
> - step_4_0db,
> - step_5_0db,
> - step_6_0db
> + step_0_5db,
> + step_1_0db,
> + step_1_5db,
> + step_2_0db,
> + step_3_0db,
> + step_4_0db,
> + step_5_0db,
> + step_6_0db
> };
>
> enum thresholdDecrement
> {
> - dec_every8th,
> - dec_every4th,
> - dec_every2nd,
> - dec_once,
> - dec_twice,
> - dec_4times,
> - dec_8times,
> - dec_16times
> + dec_every8th,
> + dec_every4th,
> + dec_every2nd,
> + dec_once,
> + dec_twice,
> + dec_4times,
> + dec_8times,
> + dec_16times
> };
>
> enum flag
> {
> - modeSwitchCompleted,
> - readyToReceive,
> - readyToSend,
> - pllLocked,
> - rssiExceededThreshold,
> - timeout,
> - automode,
> - syncAddressMatch,
> - fifoFull,
> -// fifoNotEmpty, collision with next enum; replaced by following enum...
> - fifoEmpty,
> - fifoLevelBelowThreshold,
> - fifoOverrun,
> - packetSent,
> - payloadReady,
> - crcOk,
> - batteryLow
> + modeSwitchCompleted,
> + readyToReceive,
> + readyToSend,
> + pllLocked,
> + rssiExceededThreshold,
> + timeout,
> + automode,
> + syncAddressMatch,
> + fifoFull,
> + // fifoNotEmpty, collision with next enum; replaced by following enum...
> + fifoEmpty,
> + fifoLevelBelowThreshold,
> + fifoOverrun,
> + packetSent,
> + payloadReady,
> + crcOk,
> + batteryLow
> };
>
> enum fifoFillCondition
> {
> - afterSyncInterrupt,
> - always
> + afterSyncInterrupt,
> + always
> };
>
> enum packetFormat
> {
> - packetLengthFix,
> - packetLengthVar
> + packetLengthFix,
> + packetLengthVar
> };
>
> enum txStartCondition
> {
> - fifoLevel,
> - fifoNotEmpty
> + fifoLevel,
> + fifoNotEmpty
> };
>
> enum addressFiltering
> {
> - filteringOff,
> - nodeAddress,
> - nodeOrBroadcastAddress
> + filteringOff,
> + nodeAddress,
> + nodeOrBroadcastAddress
> };
>
> enum dagc
> {
> - normalMode,
> - improve,
> - improve4LowModulationIndex
> + normalMode,
> + improve,
> + improve4LowModulationIndex
> };
>
>
> --
> 2.13.2
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line
  2017-07-22  3:51 [PATCH 3/3] staging: pi433: - style fix, space at start of line Derek Robson
  2017-07-22  8:39 ` Marcus Wolf
@ 2017-07-24  7:53 ` Dan Carpenter
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-07-24  7:53 UTC (permalink / raw)
  To: Derek Robson; +Cc: gregkh, linux, devel, linux-kernel

On Sat, Jul 22, 2017 at 03:51:21PM +1200, Derek Robson wrote:
> Fixed checkpatch errors of "please, no spaces at the start of a line"
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/pi433/rf69.c      |   4 +-
>  drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
>  2 files changed, 105 insertions(+), 105 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index d931437f0b6a..f450bbf3fbbc 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
>  	// check value for mantisse and exponent
>  	if (exponent > 7)   INVALID_PARAM;
>  	if ( (mantisse!=mantisse16) &&
> -	     (mantisse!=mantisse20) &&
> -             (mantisse!=mantisse24) ) INVALID_PARAM;
> +		(mantisse!=mantisse20) &&
> +		(mantisse!=mantisse24) ) INVALID_PARAM;
>  

This is wrong.  It should be aligned like this:

	if (exponent > 7)
		INVALID_PARAM;
	if (mantisse != mantisse16 &&
	    mantisse != mantisse20 &&
	    mantisse != mantisse24)
		INVALID_PARAM;

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-24  7:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-22  3:51 [PATCH 3/3] staging: pi433: - style fix, space at start of line Derek Robson
2017-07-22  8:39 ` Marcus Wolf
2017-07-24  7:53 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).