linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: linux-edac <linux-edac@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Tony Luck <tony.luck@intel.com>,
	Yazen Ghannam <Yazen.Ghannam@amd.com>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH 3/8] EDAC, mce_amd: Get rid of local var in amd_filter_mce()
Date: Tue, 25 Jul 2017 17:45:56 +0200	[thread overview]
Message-ID: <20170725154601.27427-4-bp@alien8.de> (raw)
In-Reply-To: <20170725154601.27427-1-bp@alien8.de>

From: Borislav Petkov <bp@suse.de>

... and use the macro for that.

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/edac/mce_amd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index c0ae47a5c7b7..a11a671c7a38 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -913,12 +913,10 @@ static inline void amd_decode_err_code(u16 ec)
  */
 static bool amd_filter_mce(struct mce *m)
 {
-	u8 xec = (m->status >> 16) & 0x1f;
-
 	/*
 	 * NB GART TLB error reporting is disabled by default.
 	 */
-	if (m->bank == 4 && xec == 0x5 && !report_gart_errors)
+	if (m->bank == 4 && XEC(m->status, 0x1f) == 0x5 && !report_gart_errors)
 		return true;
 
 	return false;
-- 
2.14.0.rc0

  parent reply	other threads:[~2017-07-25 15:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 15:45 [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 1/8] EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 2/8] EDAC, mce_amd: Get rid of most struct cpuinfo_x86 uses Borislav Petkov
2017-07-25 15:45 ` Borislav Petkov [this message]
2017-07-25 15:45 ` [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Borislav Petkov
2017-07-28  1:43   ` Steven Rostedt
2017-07-25 15:45 ` [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Borislav Petkov
2017-07-28  1:44   ` Steven Rostedt
2017-07-25 15:45 ` [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov
2017-07-28  1:47   ` Steven Rostedt
2017-07-28  7:09     ` Borislav Petkov
2017-07-28 10:51       ` Borislav Petkov
2017-07-28 12:59         ` Steven Rostedt
2017-07-28 14:09           ` Borislav Petkov
2017-07-25 15:46 ` [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov
2017-07-28  1:47   ` Steven Rostedt
2017-07-28  7:12     ` Borislav Petkov
2017-07-25 15:46 ` [RFC PATCH 8/8] EDAC, mce_amd: Issue the decoded info through the TP or printk Borislav Petkov
2017-07-27  7:10 ` [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Ingo Molnar
2017-07-27  7:58   ` Borislav Petkov
2017-07-27  8:39     ` Ingo Molnar
2017-07-27 13:09       ` Borislav Petkov
2017-07-28  6:37         ` Ingo Molnar
2017-07-28  7:15           ` Borislav Petkov
2017-07-28 15:08             ` Borislav Petkov
2017-07-28 15:38               ` Borislav Petkov
2017-07-27 16:42     ` Luck, Tony
2017-07-28  7:20       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170725154601.27427-4-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=Yazen.Ghannam@amd.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).