From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tony Luck <tony.luck@intel.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error
Date: Thu, 27 Jul 2017 15:09:09 +0200 [thread overview]
Message-ID: <20170727130909.GB28548@nazgul.tnic> (raw)
In-Reply-To: <20170727083927.jzpzeyzdoaqnxrfm@gmail.com>
On Thu, Jul 27, 2017 at 10:39:27AM +0200, Ingo Molnar wrote:
> I don't think so: we routinely log several KB per event worth of call chains via
> perf tracing just fine.
>
> So I'd suggest logging more than less, and making it more verbose is definitely
> the way to go.
No no, you're missing the point: we do dump *all* that information - it
is just spread between two tracepoints - trace_mce_record() and this new
one.
BUT(!), I just realized, I *think* I can address this much more
elegantly: extend trace_mce_record() by adding the decoded string as
its last argument. And that's fine, I'm being told, because adding
arguments to the tracepoints is not a big deal, removing them is hard.
And actually, we have added args before, come to think of it:
5828c46f2c07 x86/mce/AMD: Save MCA_IPID in MCE struct on SMCA systems
db819d60f672 x86/mce: Add support for new MCA_SYND register
So lemme look into that - it would be much nicer this way because I
don't need to add a second TP at all.
I agree with the rest but you're obviously preaching to the choir.
:-)
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2017-07-27 13:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:45 [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 1/8] EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 2/8] EDAC, mce_amd: Get rid of most struct cpuinfo_x86 uses Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 3/8] EDAC, mce_amd: Get rid of local var in amd_filter_mce() Borislav Petkov
2017-07-25 15:45 ` [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Borislav Petkov
2017-07-28 1:43 ` Steven Rostedt
2017-07-25 15:45 ` [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Borislav Petkov
2017-07-28 1:44 ` Steven Rostedt
2017-07-25 15:45 ` [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov
2017-07-28 1:47 ` Steven Rostedt
2017-07-28 7:09 ` Borislav Petkov
2017-07-28 10:51 ` Borislav Petkov
2017-07-28 12:59 ` Steven Rostedt
2017-07-28 14:09 ` Borislav Petkov
2017-07-25 15:46 ` [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov
2017-07-28 1:47 ` Steven Rostedt
2017-07-28 7:12 ` Borislav Petkov
2017-07-25 15:46 ` [RFC PATCH 8/8] EDAC, mce_amd: Issue the decoded info through the TP or printk Borislav Petkov
2017-07-27 7:10 ` [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Ingo Molnar
2017-07-27 7:58 ` Borislav Petkov
2017-07-27 8:39 ` Ingo Molnar
2017-07-27 13:09 ` Borislav Petkov [this message]
2017-07-28 6:37 ` Ingo Molnar
2017-07-28 7:15 ` Borislav Petkov
2017-07-28 15:08 ` Borislav Petkov
2017-07-28 15:38 ` Borislav Petkov
2017-07-27 16:42 ` Luck, Tony
2017-07-28 7:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727130909.GB28548@nazgul.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).