From: Vinod Koul <vinod.koul@intel.com>
To: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
"M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Fabien DESSENNE <fabien.dessenne@st.com>,
Amelie DELAUNAY <amelie.delaunay@st.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver
Date: Wed, 26 Jul 2017 10:30:07 +0530 [thread overview]
Message-ID: <20170726050007.GE3053@localhost> (raw)
In-Reply-To: <320f8def-19a4-0491-e879-b41815889e15@st.com>
On Mon, Jul 24, 2017 at 09:34:18AM +0000, Pierre Yves MORDRET wrote:
>
> On 07/21/2017 12:32 PM, Pierre Yves MORDRET wrote:
> >
> >
> > On 07/21/2017 11:54 AM, Vinod Koul wrote:
> >> On Fri, Jul 21, 2017 at 09:30:00AM +0000, Pierre Yves MORDRET wrote:
> >>>>> +static enum dma_slave_buswidth stm32_mdma_get_max_width(u32 buf_len, u32
> tlen)
> >>>>> +{
> >>>>> + enum dma_slave_buswidth max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
> >>>>> +
> >>>>> + while (((buf_len % max_width) || (tlen < max_width)) &&
> >>>>> + (max_width > DMA_SLAVE_BUSWIDTH_1_BYTE))
> >>>>> + max_width = max_width >> 1;
> >>>>
> >>>> ok, this is a bit hard to read...
> >>>
> >>> This code snippet has already been reworked and optimized. Would you mind to
> >>> provide me a example with your expectation ? Thanks
> >>
> >> Code is optimized yes, but readable no
> >>
> >> I would like readability to be improved upon...
> >>
> >
> > gotcha
> >
>
> Doest he code snippet below has a better looking for you ?
>
> for (max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
> max_width > DMA_SLAVE_BUSWIDTH_1_BYTE; max_width >>= 1)
> if (((buf_len % max_width) == 0) && (tlen >= max_width))
> break;
Am actually not sure :(
Indentation wise it is still a bit messy to follow..
How about:
for (max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
max_width > DMA_SLAVE_BUSWIDTH_1_BYTE;
max_width >>=1) {
if (((buf_len % max_width) == 0) && (tlen >= max_width))
break;
}
Thanks
--
~Vinod
next prev parent reply other threads:[~2017-07-26 4:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 12:25 [PATCH v2 0/4] Add STM32 MDMA driver Pierre-Yves MORDRET
2017-07-06 12:25 ` [PATCH v2 1/4] dt-bindings: Document the STM32 MDMA bindings Pierre-Yves MORDRET
2017-07-10 13:20 ` Rob Herring
2017-07-06 12:25 ` [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver Pierre-Yves MORDRET
2017-07-21 7:55 ` Vinod Koul
2017-07-21 9:30 ` Pierre Yves MORDRET
2017-07-21 9:54 ` Vinod Koul
2017-07-21 10:32 ` Pierre Yves MORDRET
2017-07-21 17:17 ` Vinod Koul
2017-07-24 9:34 ` Pierre Yves MORDRET
2017-07-26 5:00 ` Vinod Koul [this message]
2017-07-06 12:25 ` [PATCH v2 3/4] ARM: dts: stm32: Add MDMA support for STM32H743 SoC Pierre-Yves MORDRET
2017-07-06 12:25 ` [PATCH v2 4/4] ARM: configs: stm32: Add MDMA support in STM32 defconfig Pierre-Yves MORDRET
2017-07-20 9:37 ` [PATCH v2 0/4] Add STM32 MDMA driver Pierre Yves MORDRET
2017-07-21 6:36 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726050007.GE3053@localhost \
--to=vinod.koul@intel.com \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=cedric.madianga@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fabien.dessenne@st.com \
--cc=fabrice.gasnier@st.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).