From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Russell King <linux@armlinux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
"M'boumba Cedric Madianga" <cedric.madianga@gmail.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Fabien DESSENNE <fabien.dessenne@st.com>,
Amelie DELAUNAY <amelie.delaunay@st.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver
Date: Mon, 24 Jul 2017 09:34:18 +0000 [thread overview]
Message-ID: <320f8def-19a4-0491-e879-b41815889e15@st.com> (raw)
In-Reply-To: <20170721171735.GS3053@localhost>
On 07/21/2017 12:32 PM, Pierre Yves MORDRET wrote:
>
>
> On 07/21/2017 11:54 AM, Vinod Koul wrote:
>> On Fri, Jul 21, 2017 at 09:30:00AM +0000, Pierre Yves MORDRET wrote:
>>>>> +static enum dma_slave_buswidth stm32_mdma_get_max_width(u32 buf_len, u32
tlen)
>>>>> +{
>>>>> + enum dma_slave_buswidth max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
>>>>> +
>>>>> + while (((buf_len % max_width) || (tlen < max_width)) &&
>>>>> + (max_width > DMA_SLAVE_BUSWIDTH_1_BYTE))
>>>>> + max_width = max_width >> 1;
>>>>
>>>> ok, this is a bit hard to read...
>>>
>>> This code snippet has already been reworked and optimized. Would you mind to
>>> provide me a example with your expectation ? Thanks
>>
>> Code is optimized yes, but readable no
>>
>> I would like readability to be improved upon...
>>
>
> gotcha
>
Doest he code snippet below has a better looking for you ?
for (max_width = DMA_SLAVE_BUSWIDTH_8_BYTES;
max_width > DMA_SLAVE_BUSWIDTH_1_BYTE; max_width >>= 1)
if (((buf_len % max_width) == 0) && (tlen >= max_width))
break;
On 07/21/2017 07:17 PM, Vinod Koul wrote:
> On Fri, Jul 21, 2017 at 10:32:49AM +0000, Pierre Yves MORDRET wrote:
>>>>>> +static int stm32_mdma_set_xfer_param(struct stm32_mdma_chan *chan,
>>>>>> + enum dma_transfer_direction direction,
>>>>>> + u32 *mdma_ccr, u32 *mdma_ctcr,
>>>>>> + u32 *mdma_ctbr, u32 buf_len)
>>>>>> +{
>>>>>> + struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan);
>>>>>> + struct stm32_mdma_chan_config *chan_config = &chan->chan_config;
>>>>>> + enum dma_slave_buswidth src_addr_width, dst_addr_width;
>>>>>> + phys_addr_t src_addr, dst_addr;
>>>>>> + int src_bus_width, dst_bus_width;
>>>>>> + u32 src_maxburst, dst_maxburst, src_best_burst, dst_best_burst;
>>>>>> + u32 ccr, ctcr, ctbr, tlen;
>>>>>> +
>>>>>> + src_addr_width = chan->dma_config.src_addr_width;
>>>>>> + dst_addr_width = chan->dma_config.dst_addr_width;
>>>>>> + src_maxburst = chan->dma_config.src_maxburst;
>>>>>> + dst_maxburst = chan->dma_config.dst_maxburst;
>>>>>> + src_addr = chan->dma_config.src_addr;
>>>>>> + dst_addr = chan->dma_config.dst_addr;
>>>>>
>>>>> this doesn't seem right to me, only the periphral address would come from
>>>>> slave_config, the memory address is passed as an arg to transfer..
>>>>>
>>>>> ...
>>>>>
>>>>
>>>> Correct. But these locals are managed in the case statement below. if direction
>>>> is Mem2Dev only dst_addr(Peripheral) is considered. In the other way around with
>>>> Dev2Mem direction only src_addr(Peripheral) is considered.
>>>> However to disambiguate I can move src_addr & dst_addr affectation in the
>>>> corresponding case statement if you'd like.
>>>
>>> But below you are over writing both, so in effect this is wasted cycles..
>>> anyway latter one is more clear, so lets remove from here.
>>>
>>
>> Sorry I don't follow ... or miss something
>> For instance if direction is Mem2Dev ..._xfer_param is going to configure
>> Destination Bus width and Addr given by slave_config. ..._setup_xfer in its turn
>> will configure source given as parameter.
>> Don't the see the over-writing
>
> ah re-looking at it, yes you are right.
>
> The above two assignments threw me off, I should have read it properly.
>
> But I think calculating for src and dstn always might not be optimal as you
> would use one only, so should these be moved to respective case where they
> are used...
>
Agree. This is my planned btw
Thanks
Py.
next prev parent reply other threads:[~2017-07-24 9:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 12:25 [PATCH v2 0/4] Add STM32 MDMA driver Pierre-Yves MORDRET
2017-07-06 12:25 ` [PATCH v2 1/4] dt-bindings: Document the STM32 MDMA bindings Pierre-Yves MORDRET
2017-07-10 13:20 ` Rob Herring
2017-07-06 12:25 ` [PATCH v2 2/4] dmaengine: Add STM32 MDMA driver Pierre-Yves MORDRET
2017-07-21 7:55 ` Vinod Koul
2017-07-21 9:30 ` Pierre Yves MORDRET
2017-07-21 9:54 ` Vinod Koul
2017-07-21 10:32 ` Pierre Yves MORDRET
2017-07-21 17:17 ` Vinod Koul
2017-07-24 9:34 ` Pierre Yves MORDRET [this message]
2017-07-26 5:00 ` Vinod Koul
2017-07-06 12:25 ` [PATCH v2 3/4] ARM: dts: stm32: Add MDMA support for STM32H743 SoC Pierre-Yves MORDRET
2017-07-06 12:25 ` [PATCH v2 4/4] ARM: configs: stm32: Add MDMA support in STM32 defconfig Pierre-Yves MORDRET
2017-07-20 9:37 ` [PATCH v2 0/4] Add STM32 MDMA driver Pierre Yves MORDRET
2017-07-21 6:36 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320f8def-19a4-0491-e879-b41815889e15@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=cedric.madianga@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fabien.dessenne@st.com \
--cc=fabrice.gasnier@st.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).