* [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS
@ 2017-07-26 15:13 Arnd Bergmann
2017-07-26 15:14 ` [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann
2017-07-28 0:20 ` [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-07-26 15:13 UTC (permalink / raw)
To: netdev, Kishon Vijay Abraham I, David S . Miller, Andrew Lunn,
Florian Fainelli
Cc: linux-kernel, Raviteja Garimella, Arnd Bergmann, Raju Lakkaraju
I still see build errors in randconfig builds and have had this
patch for a while to locally work around it:
drivers/built-in.o: In function `xgene_mdio_probe':
mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register'
mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free'
mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size'
The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus
code is built-in or a module, and other drivers that use the core
code can simply depend on that, instead of having a complex
dependency line.
Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Submitted this version on June 22 2017 originally as RFC, resending
for inclusion this time.
Who should pick up the two patches? I guess they could go either
through netdev or the generic-phy tree, but they should stay together
as a series.
---
drivers/net/phy/Kconfig | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 2dda72004a7d..928fd892f167 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -7,7 +7,16 @@ menuconfig MDIO_DEVICE
help
MDIO devices and driver infrastructure code.
-if MDIO_DEVICE
+config MDIO_BUS
+ tristate
+ default m if PHYLIB=m
+ default MDIO_DEVICE
+ help
+ This internal symbol is used for link time dependencies and it
+ reflects whether the mdio_bus/mdio_device code is built as a
+ loadable module or built-in.
+
+if MDIO_BUS
config MDIO_BCM_IPROC
tristate "Broadcom iProc MDIO bus controller"
@@ -28,7 +37,6 @@ config MDIO_BCM_UNIMAC
config MDIO_BITBANG
tristate "Bitbanged MDIO buses"
- depends on !(MDIO_DEVICE=y && PHYLIB=m)
help
This module implements the MDIO bus protocol in software,
for use by low level drivers that export the ability to
@@ -127,7 +135,6 @@ config MDIO_THUNDER
tristate "ThunderX SOCs MDIO buses"
depends on 64BIT
depends on PCI
- depends on !(MDIO_DEVICE=y && PHYLIB=m)
select MDIO_CAVIUM
help
This driver supports the MDIO interfaces found on Cavium
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency
2017-07-26 15:13 [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS Arnd Bergmann
@ 2017-07-26 15:14 ` Arnd Bergmann
2017-07-28 0:20 ` David Miller
2017-07-28 0:20 ` [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-07-26 15:14 UTC (permalink / raw)
To: netdev, Kishon Vijay Abraham I, David S . Miller
Cc: Andrew Lunn, Florian Fainelli, linux-kernel, Raviteja Garimella,
Arnd Bergmann, Rafał Miłecki
The driver attempts to 'select MDIO_DEVICE', but the code
is actually a loadable module when PHYLIB=m:
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write':
phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write'
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit':
phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister'
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init':
phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register'
phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister'
Using 'depends on MDIO_BUS' instead will avoid the link error.
Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/phy/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index 37371b89b14f..64fc59c3ae6d 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3
tristate "Broadcom Northstar USB 3.0 PHY Driver"
depends on ARCH_BCM_IPROC || COMPILE_TEST
depends on HAS_IOMEM && OF
+ depends on MDIO_BUS
select GENERIC_PHY
- select MDIO_DEVICE
help
Enable this to support Broadcom USB 3.0 PHY connected to the USB
controller on Northstar family.
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS
2017-07-26 15:13 [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS Arnd Bergmann
2017-07-26 15:14 ` [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann
@ 2017-07-28 0:20 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-07-28 0:20 UTC (permalink / raw)
To: arnd
Cc: netdev, kishon, andrew, f.fainelli, linux-kernel,
raviteja.garimella, Raju.Lakkaraju
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 26 Jul 2017 17:13:59 +0200
> I still see build errors in randconfig builds and have had this
> patch for a while to locally work around it:
>
> drivers/built-in.o: In function `xgene_mdio_probe':
> mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register'
> mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free'
> mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size'
>
> The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus
> code is built-in or a module, and other drivers that use the core
> code can simply depend on that, instead of having a complex
> dependency line.
>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency
2017-07-26 15:14 ` [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann
@ 2017-07-28 0:20 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-07-28 0:20 UTC (permalink / raw)
To: arnd
Cc: netdev, kishon, andrew, f.fainelli, linux-kernel,
raviteja.garimella, rafal
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 26 Jul 2017 17:14:00 +0200
> The driver attempts to 'select MDIO_DEVICE', but the code
> is actually a loadable module when PHYLIB=m:
>
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write':
> phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write'
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit':
> phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister'
> drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init':
> phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register'
> phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister'
>
> Using 'depends on MDIO_BUS' instead will avoid the link error.
>
> Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-28 0:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 15:13 [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS Arnd Bergmann
2017-07-26 15:14 ` [PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann
2017-07-28 0:20 ` David Miller
2017-07-28 0:20 ` [PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).