* [PATCH] btrfs: Remove extra parentheses from condition in copy_items()
@ 2017-07-26 20:47 Matthias Kaehlcke
2017-07-27 10:09 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2017-07-26 20:47 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba
Cc: linux-btrfs, linux-kernel, Doug Anderson, Matthias Kaehlcke
There is no need for the extra pair of parentheses, remove it. This
fixes the following warning when building with clang:
fs/btrfs/tree-log.c:3694:10: warning: equality comparison with extraneous
parentheses [-Wparentheses-equality]
if ((i == (nr - 1)))
~~^~~~~~~~~~~
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
fs/btrfs/tree-log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f20ef211a73d..b92408a3f834 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3691,7 +3691,7 @@ static noinline int copy_items(struct btrfs_trans_handle *trans,
src_offset = btrfs_item_ptr_offset(src, start_slot + i);
- if ((i == (nr - 1)))
+ if (i == (nr - 1))
last_key = ins_keys[i];
if (ins_keys[i].type == BTRFS_INODE_ITEM_KEY) {
--
2.14.0.rc0.400.g1c36432dff-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Remove extra parentheses from condition in copy_items()
2017-07-26 20:47 [PATCH] btrfs: Remove extra parentheses from condition in copy_items() Matthias Kaehlcke
@ 2017-07-27 10:09 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-07-27 10:09 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs,
linux-kernel, Doug Anderson
> - if ((i == (nr - 1)))
> + if (i == (nr - 1))
Please remove the other set of redundant parentheses as well if you
change that line.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-27 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 20:47 [PATCH] btrfs: Remove extra parentheses from condition in copy_items() Matthias Kaehlcke
2017-07-27 10:09 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).