* [PATCH] staging: unisys: visorbus_main: constify attribute_group structures
@ 2017-07-25 22:45 Amitoj Kaur Chawla
2017-07-28 4:35 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2017-07-25 22:45 UTC (permalink / raw)
To: david.kershner, gregkh, sparmaintainer, devel, linux-kernel
Functions working with attribute_groups provided by <linux/device.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
14216 7304 832 22352 5750
drivers/staging/unisys/visorbus/visorbus_main.o
File size after:
text data bss dec hex filename
14408 7112 832 22352 5750
drivers/staging/unisys/visorbus/visorbus_main.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd..bba10dc 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -249,7 +249,7 @@ static struct attribute *channel_attrs[] = {
NULL
};
-static struct attribute_group channel_attr_grp = {
+static const struct attribute_group channel_attr_grp = {
.name = "channel",
.attrs = channel_attrs,
};
@@ -340,7 +340,7 @@ static struct attribute *dev_attrs[] = {
NULL
};
-static struct attribute_group dev_attr_grp = {
+static const struct attribute_group dev_attr_grp = {
.attrs = dev_attrs,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group structures
2017-07-25 22:45 [PATCH] staging: unisys: visorbus_main: constify attribute_group structures Amitoj Kaur Chawla
@ 2017-07-28 4:35 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-07-28 4:35 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: david.kershner, sparmaintainer, devel, linux-kernel
On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 14216 7304 832 22352 5750
> drivers/staging/unisys/visorbus/visorbus_main.o
>
> File size after:
> text data bss dec hex filename
> 14408 7112 832 22352 5750
> drivers/staging/unisys/visorbus/visorbus_main.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd..bba10dc 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -249,7 +249,7 @@ static struct attribute *channel_attrs[] = {
> NULL
> };
>
> -static struct attribute_group channel_attr_grp = {
> +static const struct attribute_group channel_attr_grp = {
> .name = "channel",
> .attrs = channel_attrs,
> };
> @@ -340,7 +340,7 @@ static struct attribute *dev_attrs[] = {
> NULL
> };
>
> -static struct attribute_group dev_attr_grp = {
> +static const struct attribute_group dev_attr_grp = {
> .attrs = dev_attrs,
> };
>
Does not apply to my tree :(
sorry,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-28 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 22:45 [PATCH] staging: unisys: visorbus_main: constify attribute_group structures Amitoj Kaur Chawla
2017-07-28 4:35 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).