* [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal
@ 2017-07-29 9:15 SZ Lin
2017-08-03 5:15 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: SZ Lin @ 2017-07-29 9:15 UTC (permalink / raw)
To: wim; +Cc: linux, linux-watchdog, linux-kernel, SZ Lin
ERROR: Use 4 digit octal (0777) not decimal permissions
This error was detected by checkpatch.pl
Signed-off-by: SZ Lin <sz.lin@moxa.com>
---
drivers/watchdog/moxart_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
index 2c4a73d1e214..05684aa89b88 100644
--- a/drivers/watchdog/moxart_wdt.c
+++ b/drivers/watchdog/moxart_wdt.c
@@ -170,7 +170,7 @@ static struct platform_driver moxart_wdt_driver = {
};
module_platform_driver(moxart_wdt_driver);
-module_param(heartbeat, int, 0);
+module_param(heartbeat, int, 0000);
MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds");
MODULE_DESCRIPTION("MOXART watchdog driver");
--
2.13.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal
2017-07-29 9:15 [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal SZ Lin
@ 2017-08-03 5:15 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-08-03 5:15 UTC (permalink / raw)
To: SZ Lin, wim; +Cc: linux-watchdog, linux-kernel
On 07/29/2017 02:15 AM, SZ Lin wrote:
> ERROR: Use 4 digit octal (0777) not decimal permissions
>
> This error was detected by checkpatch.pl
>
> Signed-off-by: SZ Lin <sz.lin@moxa.com>
I think checkpatch is overdoing it a bit here. There are more than 2,000 of those.
Plus, I really don't see the value in this change.
Guenter
> ---
> drivers/watchdog/moxart_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2c4a73d1e214..05684aa89b88 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -170,7 +170,7 @@ static struct platform_driver moxart_wdt_driver = {
> };
> module_platform_driver(moxart_wdt_driver);
>
> -module_param(heartbeat, int, 0);
> +module_param(heartbeat, int, 0000);
> MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds");
>
> MODULE_DESCRIPTION("MOXART watchdog driver");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-29 9:15 [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal SZ Lin
2017-08-03 5:15 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).