* linux-next: build warning after merge of the akpm-current tree
@ 2017-08-01 5:22 Stephen Rothwell
2017-08-01 12:01 ` [PATCH] fs, proc: remove unused variable Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2017-08-01 5:22 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Michal Hocko
Hi Andrew,
After merging the akpm-current tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
fs/proc/task_mmu.c: In function 'show_map_vma':
fs/proc/task_mmu.c:285:28: warning: unused variable 'priv' [-Wunused-variable]
struct proc_maps_private *priv = m->private;
^
Introduced by commit
14ccc3193225 ("fs, proc: remove priv argument from is_stack")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fs, proc: remove unused variable
2017-08-01 5:22 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
@ 2017-08-01 12:01 ` Arnd Bergmann
2017-08-01 12:15 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-08-01 12:01 UTC (permalink / raw)
To: Andrew Morton, Michal Hocko
Cc: Arnd Bergmann, Stephen Rothwell, Hugh Dickins, Ingo Molnar, linux-kernel
The last cleanup can go a little further, as shown by this warning:
fs/proc/task_mmu.c: In function 'show_map_vma':
fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/proc/task_mmu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 9782dedeead7..186e907187ab 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
{
struct mm_struct *mm = vma->vm_mm;
struct file *file = vma->vm_file;
- struct proc_maps_private *priv = m->private;
vm_flags_t flags = vma->vm_flags;
unsigned long ino = 0;
unsigned long long pgoff = 0;
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs, proc: remove unused variable
2017-08-01 12:01 ` [PATCH] fs, proc: remove unused variable Arnd Bergmann
@ 2017-08-01 12:15 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2017-08-01 12:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Morton, Stephen Rothwell, Hugh Dickins, Ingo Molnar, linux-kernel
On Tue 01-08-17 14:01:20, Arnd Bergmann wrote:
> The last cleanup can go a little further, as shown by this warning:
>
> fs/proc/task_mmu.c: In function 'show_map_vma':
> fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
>
> Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd! Andrew, could you fold this into
fs-proc-remove-priv-argument-from-is_stack.patch please?
> ---
> fs/proc/task_mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 9782dedeead7..186e907187ab 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
> {
> struct mm_struct *mm = vma->vm_mm;
> struct file *file = vma->vm_file;
> - struct proc_maps_private *priv = m->private;
> vm_flags_t flags = vma->vm_flags;
> unsigned long ino = 0;
> unsigned long long pgoff = 0;
> --
> 2.9.0
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-01 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 5:22 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
2017-08-01 12:01 ` [PATCH] fs, proc: remove unused variable Arnd Bergmann
2017-08-01 12:15 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).