linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sched/autogroup: Fix error reporting inside autogroup_create()
@ 2017-08-02  8:43 Anshuman Khandual
  2017-08-10 16:40 ` [tip:sched/core] sched/autogroup: Fix error reporting printk text in autogroup_create() tip-bot for Anshuman Khandual
  0 siblings, 1 reply; 2+ messages in thread
From: Anshuman Khandual @ 2017-08-02  8:43 UTC (permalink / raw)
  To: linux-mm, linux-kernel; +Cc: mingo

Its kzalloc() not kmalloc() which has failed earlier. While here
remove a redundant empty line.

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 kernel/sched/autogroup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
index da39489..de6d7f4 100644
--- a/kernel/sched/autogroup.c
+++ b/kernel/sched/autogroup.c
@@ -71,7 +71,6 @@ static inline struct autogroup *autogroup_create(void)
 		goto out_fail;
 
 	tg = sched_create_group(&root_task_group);
-
 	if (IS_ERR(tg))
 		goto out_free;
 
@@ -101,7 +100,7 @@ static inline struct autogroup *autogroup_create(void)
 out_fail:
 	if (printk_ratelimit()) {
 		printk(KERN_WARNING "autogroup_create: %s failure.\n",
-			ag ? "sched_create_group()" : "kmalloc()");
+			ag ? "sched_create_group()" : "kzalloc()");
 	}
 
 	return autogroup_kref_get(&autogroup_default);
-- 
1.8.5.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:sched/core] sched/autogroup: Fix error reporting printk text in autogroup_create()
  2017-08-02  8:43 [PATCH] sched/autogroup: Fix error reporting inside autogroup_create() Anshuman Khandual
@ 2017-08-10 16:40 ` tip-bot for Anshuman Khandual
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Anshuman Khandual @ 2017-08-10 16:40 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: peterz, hpa, linux-kernel, khandual, torvalds, tglx, mingo

Commit-ID:  1e58565e6d147751d85ee9e692d1226059b3318f
Gitweb:     http://git.kernel.org/tip/1e58565e6d147751d85ee9e692d1226059b3318f
Author:     Anshuman Khandual <khandual@linux.vnet.ibm.com>
AuthorDate: Wed, 2 Aug 2017 14:13:00 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 10 Aug 2017 17:06:03 +0200

sched/autogroup: Fix error reporting printk text in autogroup_create()

Its kzalloc() not kmalloc() which has failed earlier. While here
remove a redundant empty line.

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/20170802084300.29487-1-khandual@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/autogroup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
index da39489..de6d7f4 100644
--- a/kernel/sched/autogroup.c
+++ b/kernel/sched/autogroup.c
@@ -71,7 +71,6 @@ static inline struct autogroup *autogroup_create(void)
 		goto out_fail;
 
 	tg = sched_create_group(&root_task_group);
-
 	if (IS_ERR(tg))
 		goto out_free;
 
@@ -101,7 +100,7 @@ out_free:
 out_fail:
 	if (printk_ratelimit()) {
 		printk(KERN_WARNING "autogroup_create: %s failure.\n",
-			ag ? "sched_create_group()" : "kmalloc()");
+			ag ? "sched_create_group()" : "kzalloc()");
 	}
 
 	return autogroup_kref_get(&autogroup_default);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-10 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02  8:43 [PATCH] sched/autogroup: Fix error reporting inside autogroup_create() Anshuman Khandual
2017-08-10 16:40 ` [tip:sched/core] sched/autogroup: Fix error reporting printk text in autogroup_create() tip-bot for Anshuman Khandual

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).