[PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls

[PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls

[Jonathan Liu]

During panel removal or system shutdown panel_simple_disable is called
which disables the panel backlight but the panel is still powered due to
missing calls to panel_simple_unprepare.

Fixes: d02fd93e2cd8 ("drm/panel: simple - Disable panel on shutdown")
Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa759e06e..234af81fb3d0 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -369,6 +369,7 @@ static int panel_simple_remove(struct device *dev)
 	drm_panel_remove(&panel->base);
 
 	panel_simple_disable(&panel->base);
+	panel_simple_unprepare(&panel->base);
 
 	if (panel->ddc)
 		put_device(&panel->ddc->dev);
@@ -384,6 +385,7 @@ static void panel_simple_shutdown(struct device *dev)
 	struct panel_simple *panel = dev_get_drvdata(dev);
 
 	panel_simple_disable(&panel->base);
+	panel_simple_unprepare(&panel->base);
 }
 
 static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = {
-- 
2.13.2

Re: [PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On Mon, Aug 07, 2017 at 09:55:45PM +1000, Jonathan Liu wrote:
> During panel removal or system shutdown panel_simple_disable is called
> which disables the panel backlight but the panel is still powered due to
> missing calls to panel_simple_unprepare.
> 
> Fixes: d02fd93e2cd8 ("drm/panel: simple - Disable panel on shutdown")
> Cc: stable@vger.kernel.org # v3.16+
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied to drm-misc-next, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]