[PATCH] kbuild: Update example for ccflags-y usage

[PATCH] kbuild: Update example for ccflags-y usage

[Sedat Dilek]

From: Sedat Dilek <sedat.dilek@gmail.com>

The old example to describe ccflags-y usage is no more valid.

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 Documentation/kbuild/makefiles.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
index 7003141a6d4f..cadfa882c275 100644
--- a/Documentation/kbuild/makefiles.txt
+++ b/Documentation/kbuild/makefiles.txt
@@ -297,9 +297,9 @@ more details, with real examples.
 	ccflags-y specifies options for compiling with $(CC).
 
 	Example:
-		# drivers/acpi/Makefile
-		ccflags-y := -Os
-		ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT
+		# drivers/acpi/acpica/Makefile
+		ccflags-y						:= -Os -D_LINUX -DBUILDING_ACPICA
+		ccflags-$(CONFIG_ACPI_DEBUG)	+= -DACPI_DEBUG_OUTPUT
 
 	This variable is necessary because the top Makefile owns the
 	variable $(KBUILD_CFLAGS) and uses it for compilation flags for the
-- 
2.11.0

Re: [PATCH] kbuild: Update example for ccflags-y usage

[Jonathan Corbet]

On Mon, 24 Jul 2017 17:27:05 +0200
Sedat Dilek <sedat.dilek@credativ.de> wrote:

> The old example to describe ccflags-y usage is no more valid.
> 
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>

I've applied this; had to clean up some whitespace weirdness on the way.

Thanks,

jon

Re: [PATCH] kbuild: Update example for ccflags-y usage

[Sedat Dilek]

On Mon, Aug 7, 2017 at 10:24 PM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Mon, 24 Jul 2017 17:27:05 +0200
> Sedat Dilek <sedat.dilek@credativ.de> wrote:
>
>> The old example to describe ccflags-y usage is no more valid.
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> I've applied this; had to clean up some whitespace weirdness on the way.
>

My apologies for this, forgot to run the checkpatch-script.

Will this go to Linux v4.13 or v4.14?

Thanks.

- Sedat -

Re: [PATCH] kbuild: Update example for ccflags-y usage

[Jonathan Corbet]

On Tue, 8 Aug 2017 14:36:02 +0200
Sedat Dilek <sedat.dilek@gmail.com> wrote:

> Will this go to Linux v4.13 or v4.14?

It's queued for 4.14.

jon