From: Mark Brown <broonie@kernel.org>
To: Donglin Peng <dolinux.peng@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: compress: Remove duplicated code
Date: Mon, 7 Aug 2017 16:07:14 +0100 [thread overview]
Message-ID: <20170807150714.e7aecqskfelp7h5z@sirena.org.uk> (raw)
In-Reply-To: <CAErzpmsPRYKmu_CMPPXEohjB-dbuqux4v12t5r9-E6dV3sXnMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Mon, Aug 07, 2017 at 09:18:09PM +0800, Donglin Peng wrote:
> The value of the variable new_name is assigned repeatedly.
> @@ -737,9 +737,6 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime
> *rtd, int num)
> }
>
> /* check client and interface hw capabilities */
> - snprintf(new_name, sizeof(new_name), "%s %s-%d",
> - rtd->dai_link->stream_name, codec_dai->name, num);
> -
Are you sure that this is the assignment that should be deleted, and if
so why? Note that it's both conditionally and unconditionally assigned
later on... Some words in the commit log about why this copy is removed
would be helpful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
parent reply other threads:[~2017-08-07 15:07 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAErzpmsPRYKmu_CMPPXEohjB-dbuqux4v12t5r9-E6dV3sXnMg@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807150714.e7aecqskfelp7h5z@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dolinux.peng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).