* [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()
@ 2017-08-08 4:35 Gustavo A. R. Silva
2017-08-11 3:08 ` Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-08 4:35 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin, Heiko Stuebner
Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel,
Gustavo A. R. Silva
platform_get_irq() returns an error code, but the rockchip_thermal driver
ignores it and always returns -EINVAL. This is not correct and, prevents
-EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/thermal/rockchip_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 4c77965..6ca9747 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1068,8 +1068,8 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq resource?\n");
- return -EINVAL;
+ dev_err(&pdev->dev, "no irq resource: %d\n", irq);
+ return irq;
}
thermal = devm_kzalloc(&pdev->dev, sizeof(struct rockchip_thermal_data),
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()
2017-08-08 4:35 [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe() Gustavo A. R. Silva
@ 2017-08-11 3:08 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2017-08-11 3:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Eduardo Valentin, Heiko Stuebner
Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the rockchip_thermal
> driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents
> -EPROBE_DEFER from being propagated properly.
>
> Notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co
> mmit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
thanks,
rui
> ---
> drivers/thermal/rockchip_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c
> b/drivers/thermal/rockchip_thermal.c
> index 4c77965..6ca9747 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -1068,8 +1068,8 @@ static int rockchip_thermal_probe(struct
> platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "no irq resource?\n");
> - return -EINVAL;
> + dev_err(&pdev->dev, "no irq resource: %d\n", irq);
> + return irq;
> }
>
> thermal = devm_kzalloc(&pdev->dev, sizeof(struct
> rockchip_thermal_data),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-11 3:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 4:35 [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe() Gustavo A. R. Silva
2017-08-11 3:08 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).