* Question about bh1770glc.ko
@ 2017-08-08 12:46 Anton Volkov
2017-08-08 14:57 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Anton Volkov @ 2017-08-08 12:46 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, ldv-project, Alexey Khoroshilov, samu.p.onkalo
Hello.
In drivers/misc/bh1770glc.c several functions have comments stating that
they must be called under lock protection, e.g.
bh1770_prox_mode_control, bh1770_lux_interrupt_control, bh1770_lux_rate,
bh1770_chip_on. However there are places where they are called without
lock being held, e.g. during the bh1770_resume. Do you know anything
about whether this is intended or this is a bug?
Thank you for your time.
-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avolkov@ispras.ru
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question about bh1770glc.ko
2017-08-08 12:46 Question about bh1770glc.ko Anton Volkov
@ 2017-08-08 14:57 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-08-08 14:57 UTC (permalink / raw)
To: Anton Volkov
Cc: arnd, linux-kernel, ldv-project, Alexey Khoroshilov, samu.p.onkalo
On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote:
> Hello.
>
> In drivers/misc/bh1770glc.c several functions have comments stating that
> they must be called under lock protection, e.g. bh1770_prox_mode_control,
> bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However there
> are places where they are called without lock being held, e.g. during the
> bh1770_resume. Do you know anything about whether this is intended or this
> is a bug?
>
> Thank you for your time.
I have no idea, sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-08 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 12:46 Question about bh1770glc.ko Anton Volkov
2017-08-08 14:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).