From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.
Date: Wed, 9 Aug 2017 16:42:53 +0200 [thread overview]
Message-ID: <20170809164253.59bcc002@bbrezillon> (raw)
In-Reply-To: <87r2wrm3ub.fsf@eliezer.anholt.net>
Le Fri, 04 Aug 2017 14:15:56 -0700,
Eric Anholt <eric@anholt.net> a écrit :
> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
>
> > On Tue, 18 Jul 2017 14:05:05 -0700
> > Eric Anholt <eric@anholt.net> wrote:
> >
> >> The incoming mode might have a missing vrefresh field if it came from
> >> drmModeSetCrtc(), which the kernel is supposed to calculate using
> >> drm_mode_vrefresh(). We could either use that or the adjusted_mode's
> >> original vrefresh value.
> >>
> >> However, we can maintain a more exact vrefresh value (not just the
> >> integer approximation), by scaling by the ratio of our clocks.
> >>
> >> v2: Use math suggested by Andrzej Hajda instead.
> >>
> >> Signed-off-by: Eric Anholt <eric@anholt.net>
> >> ---
> >> drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> >> index 629d372633e6..57213f4e3c72 100644
> >> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> >> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> >> @@ -866,7 +866,8 @@ static bool vc4_dsi_encoder_mode_fixup(struct drm_encoder *encoder,
> >> adjusted_mode->clock = pixel_clock_hz / 1000 + 1;
> >>
> >> /* Given the new pixel clock, adjust HFP to keep vrefresh the same. */
> >> - adjusted_mode->htotal = pixel_clock_hz / (mode->vrefresh * mode->vtotal);
> >> + adjusted_mode->htotal = (pixel_clock_hz / 1000 * mode->htotal /
> >> + mode->clock);
> >
> > Hm, I'm not sure I understand this. Shouldn't we have something like:
> >
> > adjusted_mode->htotal = (adjusted_mode->clock * mode->htotal) /
> > mode->clock;
> >
> > Is there a reason for doing '+ 1' when you calculate the adjusted
> > pixel clock rate but not here?
>
> We're actually expecting to get within epsilon of pixel_clock_hz, but we
> have to bump our clk_set_rate() to a higher value because the clock
> driver will give you a bad divider if you ask for anything less than the
> rate it can provide.
>
> How about I don't increment the adjusted_mode->clock (since it'll be
> userspace visible I think), and instead move that and the "Round up"
> comment to the clk_set_rate()?
Sounds good.
prev parent reply other threads:[~2017-08-09 14:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:05 [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math Eric Anholt
2017-07-18 21:05 ` [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge Eric Anholt
2017-07-19 8:58 ` Philippe CORNU
2017-07-26 22:43 ` Eric Anholt
2017-08-04 13:46 ` Laurent Pinchart
2017-08-04 14:57 ` Laurent Pinchart
2017-08-04 20:43 ` Eric Anholt
2017-08-04 21:25 ` Laurent Pinchart
2017-08-04 22:19 ` Ilia Mirkin
2017-08-05 10:59 ` Noralf Trønnes
2017-08-05 14:47 ` Noralf Trønnes
2017-08-07 9:25 ` Daniel Vetter
2017-08-07 10:22 ` Laurent Pinchart
2017-08-07 14:37 ` Noralf Trønnes
2017-08-07 14:59 ` Daniel Vetter
2017-08-07 21:54 ` Laurent Pinchart
2017-07-18 21:05 ` [PATCH v5 3/6] drm/vc4: Delay DSI host registration until the panel has probed Eric Anholt
2017-08-04 9:04 ` Boris Brezillon
2017-07-18 21:05 ` [PATCH v5 4/6] drm: Allow DSI devices to be registered before the host registers Eric Anholt
2017-07-19 20:31 ` Eric Anholt
2017-07-18 21:05 ` [PATCH v5 5/6] dt-bindings: Document the Raspberry Pi Touchscreen nodes Eric Anholt
2017-07-18 21:05 ` [PATCH v5 6/6] drm/panel: Add support for the Raspberry Pi 7" Touchscreen Eric Anholt
2017-08-04 8:53 ` [PATCH v5 1/6] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math Boris Brezillon
2017-08-04 21:15 ` Eric Anholt
2017-08-09 14:42 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809164253.59bcc002@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).