From: Rob Herring <robh@kernel.org>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH 2/6] dt-bindings: ti,omap-hsmmc: Add 66AK2G mmc controller
Date: Wed, 9 Aug 2017 19:03:08 -0500 [thread overview]
Message-ID: <20170810000308.45bhcka2z4vk4yhm@rob-hp-laptop> (raw)
In-Reply-To: <20170801044119.16201-3-lokeshvutla@ti.com>
On Tue, Aug 01, 2017 at 10:11:15AM +0530, Lokesh Vutla wrote:
> Update the ti,omap-hsmmc.txt to include information about
> 66AK2G specific mmc controller. Also cleanup the entries
> under optional properties to look a bit nicer.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 52 +++++++++++++++-------
> 1 file changed, 37 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> index 0e026c151c1c..016741402e37 100644
> --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt
> @@ -1,33 +1,55 @@
> -* TI Highspeed MMC host controller for OMAP
> +* TI Highspeed MMC host controller for OMAP and 66AK2G family.
>
> -The Highspeed MMC Host Controller on TI OMAP family
> +The Highspeed MMC Host Controller on TI OMAP and 66AK2G family
> provides an interface for MMC, SD, and SDIO types of memory cards.
>
> This file documents differences between the core properties described
> by mmc.txt and the properties used by the omap_hsmmc driver.
>
> Required properties:
> +--------------------
> - compatible:
> Should be "ti,omap2-hsmmc", for OMAP2 controllers
> Should be "ti,omap3-hsmmc", for OMAP3 controllers
> Should be "ti,omap3-pre-es3-hsmmc" for OMAP3 controllers pre ES3.0
> Should be "ti,omap4-hsmmc", for OMAP4 controllers
> Should be "ti,am33xx-hsmmc", for AM335x controllers
> -- ti,hwmods: Must be "mmc<n>", n is controller instance starting 1
> + Should be "ti,k2g-hsmmc", "ti,omap4-hsmmc" for 66AK2G controllers.
Same comment here.
> +
> +SoC specific required properties:
> +---------------------------------
> +The following are mandatory properties for OMAPs, AM33xx and AM43xx SoCs only:
> +- ti,hwmods: Must be "mmc<n>", n is controller instance starting 1.
> +
> +The following are mandatory properties for 66AK2G SoCs only:
> +- power-domains:Should contain a phandle to a PM domain provider node
> + and an args specifier containing the MMC device id
> + value. This property is as per the binding,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
> +- clocks: Must contain an entry for each entry in clock-names. Should
> + be defined as per the he appropriate clock bindings consumer
> + usage in Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> +- clock-names: Shall be "fck" for the functional clock,
> + and "mmchsdb_fck" for the debounce clock.
> +
>
> Optional properties:
> -ti,dual-volt: boolean, supports dual voltage cards
> -<supply-name>-supply: phandle to the regulator device tree node
> -"supply-name" examples are "vmmc", "vmmc_aux"(deprecated)/"vqmmc" etc
> -ti,non-removable: non-removable slot (like eMMC)
> -ti,needs-special-reset: Requires a special softreset sequence
> -ti,needs-special-hs-handling: HSMMC IP needs special setting for handling High Speed
> -dmas: List of DMA specifiers with the controller specific format
> -as described in the generic DMA client binding. A tx and rx
> -specifier is required.
> -dma-names: List of DMA request names. These strings correspond
> -1:1 with the DMA specifiers listed in dmas. The string naming is
> -to be "rx" and "tx" for RX and TX DMA requests, respectively.
> +--------------------
> +- ti,dual-volt: boolean, supports dual voltage cards
> +- <supply-name>-supply: phandle to the regulator device tree node
> + "supply-name" examples are "vmmc",
> + "vmmc_aux"(deprecated)/"vqmmc" etc
> +- ti,non-removable: non-removable slot (like eMMC)
> +- ti,needs-special-reset: Requires a special softreset sequence
> +- ti,needs-special-hs-handling: HSMMC IP needs special setting
> + for handling High Speed
> +- dmas: List of DMA specifiers with the controller specific
> + format as described in the generic DMA client
> + binding. A tx and rx specifier is required.
> +- dma-names: List of DMA request names. These strings correspond
> + 1:1 with the DMA specifiers listed in dmas.
> + The string naming is to be "rx" and "tx" for
> + RX and TX DMA requests, respectively.
Is there some change here or just reformatting? Please make reformatting
a separate patch.
Rob
next prev parent reply other threads:[~2017-08-10 0:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 4:41 [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC Lokesh Vutla
2017-08-01 4:41 ` [PATCH 1/6] dt-bindings: ti,edma: Add 66AK2G specific information Lokesh Vutla
2017-08-01 12:50 ` Peter Ujfalusi
2017-08-02 17:03 ` Lokesh Vutla
2017-08-03 5:34 ` Sekhar Nori
2017-08-09 23:57 ` Rob Herring
2017-08-10 0:00 ` Rob Herring
2017-08-12 5:43 ` Lokesh Vutla
2017-08-01 4:41 ` [PATCH 2/6] dt-bindings: ti,omap-hsmmc: Add 66AK2G mmc controller Lokesh Vutla
2017-08-10 0:03 ` Rob Herring [this message]
2017-08-01 4:41 ` [PATCH 3/6] ARM: dts: keystone-k2g: Add eDMA nodes Lokesh Vutla
2017-08-01 4:41 ` [PATCH 4/6] ARM: dts: keystone-k2g: add MMC0 and MMC1 nodes Lokesh Vutla
2017-08-01 4:41 ` [PATCH 5/6] ARM: dts: keystone-k2g-evm: Enable MMC0 and MMC1 Lokesh Vutla
2017-08-01 4:41 ` [PATCH 6/6] ARM: configs: keystone: Enable MMC and regulators Lokesh Vutla
2017-08-01 18:10 ` [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC Santosh Shilimkar
2017-08-02 3:52 ` Keerthy
2017-08-07 13:38 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810000308.45bhcka2z4vk4yhm@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).