From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>,
Sekhar Nori <nsekhar@ti.com>, Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH 1/6] dt-bindings: ti,edma: Add 66AK2G specific information
Date: Tue, 1 Aug 2017 15:50:03 +0300 [thread overview]
Message-ID: <31fe2206-675b-5425-412f-0033017f6511@ti.com> (raw)
In-Reply-To: <20170801044119.16201-2-lokeshvutla@ti.com>
On 2017-08-01 07:41, Lokesh Vutla wrote:
> Update ti,edma binding documentation to reflect 66AK2G specific
> properties.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> Documentation/devicetree/bindings/dma/ti-edma.txt | 95 +++++++++++++++++++++--
> 1 file changed, 90 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
> index 18090e7226b4..05fe2931d025 100644
> --- a/Documentation/devicetree/bindings/dma/ti-edma.txt
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -9,7 +9,12 @@ execute the actual DMA tansfer.
> eDMA3 Channel Controller
>
> Required properties:
> -- compatible: "ti,edma3-tpcc" for the channel controller(s)
> +--------------------
> +- compatible: Should be:
> + - "ti,edma3-tpcc" for the channel controller(s) on OMAP,
> + AM33xx and AM43xx SoCs.
> + - "ti,k2g-edma3-tpcc", "ti,edma3-tpcc" for the
> + channel controller(s) on 66AK2G.
> - #dma-cells: Should be set to <2>. The first number is the DMA request
> number and the second is the TC the channel is serviced on.
> - reg: Memory map of eDMA CC
> @@ -19,8 +24,19 @@ Required properties:
> - ti,tptcs: List of TPTCs associated with the eDMA in the following form:
> <&tptc_phandle TC_priority_number>. The highest priority is 0.
>
> +SoC-specific Required properties:
> +--------------------------------
> +The following are mandatory properties for OMAP, AM33xx and AM43xx SoCs only:
> +- ti,hwmods: Name of the hwmods associated to the eDMA CC.
> +
> +The following are mandatory properties for 66AK2G SoCs only:
> +- power-domains:Should contain a phandle to a PM domain provider node
> + and an args specifier containing the device id
> + value. This property is as per the binding,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
> +
> Optional properties:
> -- ti,hwmods: Name of the hwmods associated to the eDMA CC
> +-------------------
> - ti,edma-memcpy-channels: List of channels allocated to be used for memcpy, iow
> these channels will be SW triggered channels. See example.
> - ti,edma-reserved-slot-ranges: PaRAM slot ranges which should not be used by
> @@ -31,17 +47,34 @@ Optional properties:
> eDMA3 Transfer Controller
>
> Required properties:
> -- compatible: "ti,edma3-tptc" for the transfer controller(s)
> +--------------------
> +- compatible: Should be:
> + - "ti,edma3-tptc" for the transfer controller(s) on OMAP,
> + AM33xx and AM43xx SoCs.
> + - "ti,k2g-edma3-tptc", "ti,edma3-tptc" for the
> + transfer controller(s) on 66AK2G.
> - reg: Memory map of eDMA TC
> - interrupts: Interrupt number for TCerrint.
>
> +SoC-specific Required properties:
> +--------------------------------
> +The following are mandatory properties for OMAP, AM33xx and AM43xx SoCs only:
> +- ti,hwmods: Name of the hwmods associated to the eDMA TC.
> +
> +The following are mandatory properties for 66AK2G SoCs only:
> +- power-domains:Should contain a phandle to a PM domain provider node
> + and an args specifier containing the device id
> + value. This property is as per the binding,
> + Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
> +
> Optional properties:
> -- ti,hwmods: Name of the hwmods associated to the given eDMA TC
> +-------------------
> - interrupt-names: "edma3_tcerrint"
>
> ------------------------------------------------------------------------------
> -Example:
> +Examples:
Do we really need to expand the examples to have identical set, but with
power-domains?
>
> +1.
> edma: edma@49000000 {
> compatible = "ti,edma3-tpcc";
> ti,hwmods = "tpcc";
> @@ -109,6 +142,58 @@ mcasp0: mcasp@48038000 {
> dma-names = "tx", "rx";
> };
>
> +2.
> +edma1: edma@02728000 {
> + compatible = "ti,k2g-edma3-tpcc", "ti,edma3-tpcc";
> + reg = <0x02728000 0x8000>;
> + reg-names = "edma3_cc";
> + interrupts = <GIC_SPI 208 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 219 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 220 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "edma3_ccint", "emda3_mperr",
> + "edma3_ccerrint";
> + dma-requests = <64>;
> + #dma-cells = <2>;
> +
> + ti,tptcs = <&edma1_tptc0 7>, <&edma1_tptc1 0>;
> +
> + /*
> + * memcpy is disabled, can be enabled with:
> + * ti,edma-memcpy-channels = <12 13 14 15>;
> + * for example.
> + */
> +
> + power-domains = <&k2g_pds 0x4f>;
> +};
> +
> +edma1_tptc0: tptc@027b0000 {
> + compatible = "ti,k2g-edma3-tptc", "ti,edma3-tptc";
> + reg = <0x027b0000 0x400>;
> + power-domains = <&k2g_pds 0x4f>;
> +};
> +
> +edma1_tptc1: tptc@027b8000 {
> + compatible = "ti, k2g-edma3-tptc", "ti,edma3-tptc";
> + reg = <0x027b8000 0x400>;
> + power-domains = <&k2g_pds 0x4f>;
> +};
> +
> +mmc0: mmc@23000000 {
> + compatible = "ti,k2g-hsmmc", "ti,omap4-hsmmc";
> + reg = <0x23000000 0x400>;
> + interrupts = <GIC_SPI 96 IRQ_TYPE_EDGE_RISING>;
> + dmas = <&edma1 24 0>, <&edma1 25 0>;
> + dma-names = "tx", "rx";
> + bus-width = <4>;
> + ti,needs-special-reset;
> + no-1-8-v;
> + max-frequency = <96000000>;
> + power-domains = <&k2g_pds 0xb>;
> + clocks = <&k2g_clks 0xb 1>, <&k2g_clks 0xb 2>;
> + clock-names = "fck", "mmchsdb_fck";
> + status = "disabled";
> +};
> +
> ------------------------------------------------------------------------------
> DEPRECATED binding, new DTS files must use the ti,edma3-tpcc/ti,edma3-tptc
> binding.
>
- Péter
next prev parent reply other threads:[~2017-08-01 12:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 4:41 [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC Lokesh Vutla
2017-08-01 4:41 ` [PATCH 1/6] dt-bindings: ti,edma: Add 66AK2G specific information Lokesh Vutla
2017-08-01 12:50 ` Peter Ujfalusi [this message]
2017-08-02 17:03 ` Lokesh Vutla
2017-08-03 5:34 ` Sekhar Nori
2017-08-09 23:57 ` Rob Herring
2017-08-10 0:00 ` Rob Herring
2017-08-12 5:43 ` Lokesh Vutla
2017-08-01 4:41 ` [PATCH 2/6] dt-bindings: ti,omap-hsmmc: Add 66AK2G mmc controller Lokesh Vutla
2017-08-10 0:03 ` Rob Herring
2017-08-01 4:41 ` [PATCH 3/6] ARM: dts: keystone-k2g: Add eDMA nodes Lokesh Vutla
2017-08-01 4:41 ` [PATCH 4/6] ARM: dts: keystone-k2g: add MMC0 and MMC1 nodes Lokesh Vutla
2017-08-01 4:41 ` [PATCH 5/6] ARM: dts: keystone-k2g-evm: Enable MMC0 and MMC1 Lokesh Vutla
2017-08-01 4:41 ` [PATCH 6/6] ARM: configs: keystone: Enable MMC and regulators Lokesh Vutla
2017-08-01 18:10 ` [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC Santosh Shilimkar
2017-08-02 3:52 ` Keerthy
2017-08-07 13:38 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fe2206-675b-5425-412f-0033017f6511@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).