* [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
@ 2017-08-10 8:53 Thomas Meyer
2017-08-10 18:24 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Meyer @ 2017-08-10 8:53 UTC (permalink / raw)
To: paul.burton, linux-kernel; +Cc: Thomas Meyer
This avoids the MODPOST error:
ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
drivers/auxdisplay/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 9ae6681c90ad..9088c66e4c08 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -135,6 +135,7 @@ config CFAG12864B_RATE
config IMG_ASCII_LCD
tristate "Imagination Technologies ASCII LCD Display"
+ depends on HAS_IOMEM
default y if MIPS_MALTA || MIPS_SEAD3
select SYSCON
help
--
2.13.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
2017-08-10 8:53 [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM Thomas Meyer
@ 2017-08-10 18:24 ` Randy Dunlap
2017-11-27 20:05 ` Thomas Meyer
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2017-08-10 18:24 UTC (permalink / raw)
To: Thomas Meyer, paul.burton, linux-kernel
On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> This avoids the MODPOST error:
> ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
> drivers/auxdisplay/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 9ae6681c90ad..9088c66e4c08 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -135,6 +135,7 @@ config CFAG12864B_RATE
>
> config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> + depends on HAS_IOMEM
> default y if MIPS_MALTA || MIPS_SEAD3
> select SYSCON
> help
>
I posted the same patch on 2017-JAN-01, so I agree with it.
https://lkml.org/lkml/2017/1/1/87
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
2017-08-10 18:24 ` Randy Dunlap
@ 2017-11-27 20:05 ` Thomas Meyer
2017-11-27 20:37 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Meyer @ 2017-11-27 20:05 UTC (permalink / raw)
To: Randy Dunlap, torvalds; +Cc: paul.burton, linux-kernel
On Thu, Aug 10, 2017 at 11:24:04AM -0700, Randy Dunlap wrote:
> On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> > This avoids the MODPOST error:
> > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
> >
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> > drivers/auxdisplay/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index 9ae6681c90ad..9088c66e4c08 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -135,6 +135,7 @@ config CFAG12864B_RATE
> >
> > config IMG_ASCII_LCD
> > tristate "Imagination Technologies ASCII LCD Display"
> > + depends on HAS_IOMEM
> > default y if MIPS_MALTA || MIPS_SEAD3
> > select SYSCON
> > help
> >
>
> I posted the same patch on 2017-JAN-01, so I agree with it.
>
> https://lkml.org/lkml/2017/1/1/87
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
No response from the maintainer yet. I think this driver is actually unmaintained.
What to do now?
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
2017-11-27 20:05 ` Thomas Meyer
@ 2017-11-27 20:37 ` Linus Torvalds
0 siblings, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2017-11-27 20:37 UTC (permalink / raw)
To: Thomas Meyer; +Cc: Randy Dunlap, Paul Burton, Linux Kernel Mailing List
On Mon, Nov 27, 2017 at 12:05 PM, Thomas Meyer <thomas@m3y3r.de> wrote:
>
> No response from the maintainer yet. I think this driver is actually unmaintained.
> What to do now?
Applied directly.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-27 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-10 8:53 [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM Thomas Meyer
2017-08-10 18:24 ` Randy Dunlap
2017-11-27 20:05 ` Thomas Meyer
2017-11-27 20:37 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).