* [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port()
@ 2017-08-10 9:54 Dan Carpenter
2017-08-11 21:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-08-10 9:54 UTC (permalink / raw)
To: Yisen Zhuang
Cc: Salil Mehta, David S. Miller, Jiri Pirko, Jamal Hadi Salim,
lipeng, netdev, linux-kernel, kernel-janitors
This function has a copy and paste bug so it accidentally calls the add
function instead of the delete function.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
index 069ae426aa24..e519795dff7c 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
@@ -1138,7 +1138,7 @@ static void hns3_del_tunnel_port(struct net_device *netdev, u16 port,
udp_tnl->dst_port = 0;
/* TBD send command to hardware to del port */
if (h->ae_algo->ops->del_tunnel_udp)
- h->ae_algo->ops->add_tunnel_udp(h, port);
+ h->ae_algo->ops->del_tunnel_udp(h, port);
}
/* hns3_nic_udp_tunnel_add - Get notifiacetion about UDP tunnel ports
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port()
2017-08-10 9:54 [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port() Dan Carpenter
@ 2017-08-11 21:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-11 21:32 UTC (permalink / raw)
To: dan.carpenter
Cc: yisen.zhuang, salil.mehta, jiri, jhs, lipeng321, netdev,
linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 10 Aug 2017 12:54:59 +0300
> This function has a copy and paste bug so it accidentally calls the add
> function instead of the delete function.
>
> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-11 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-10 9:54 [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port() Dan Carpenter
2017-08-11 21:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).