* [PATCH] hwmon: aspeed: add THERMAL dependency
@ 2017-08-15 14:47 Arnd Bergmann
2017-08-15 14:56 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-08-15 14:47 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck
Cc: Arnd Bergmann, Jaghathiswari Rankappagounder Natarajan,
linux-hwmon, linux-kernel
With CONFIG_THERMAL=m, a built-in aspeed pwm tacho driver causes
a link error:
drivers/hwmon/aspeed-pwm-tacho.o: In function `aspeed_pwm_tacho_probe':
aspeed-pwm-tacho.c:(.text+0x7f0): undefined reference to `thermal_of_cooling_device_register'
This adds a dependency similar to what other hwmon drivers use,
ensuring that the aspeed driver cannot be built-in in this
case but has to be a module. With THERMAL=n, we still allow building it.
Fixes: 2d7a548a3eff ("drivers: hwmon: Support for ASPEED PWM/Fan tach")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 5ef2814345ef..5b9a61f766ac 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -343,6 +343,7 @@ config SENSORS_ASB100
config SENSORS_ASPEED
tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+ depends on THERMAL || THERMAL=n
select REGMAP
help
This driver provides support for ASPEED AST2400/AST2500 PWM
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: aspeed: add THERMAL dependency
2017-08-15 14:47 [PATCH] hwmon: aspeed: add THERMAL dependency Arnd Bergmann
@ 2017-08-15 14:56 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-08-15 14:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jean Delvare, Jaghathiswari Rankappagounder Natarajan,
linux-hwmon, linux-kernel
On Tue, Aug 15, 2017 at 04:47:47PM +0200, Arnd Bergmann wrote:
> With CONFIG_THERMAL=m, a built-in aspeed pwm tacho driver causes
> a link error:
>
> drivers/hwmon/aspeed-pwm-tacho.o: In function `aspeed_pwm_tacho_probe':
> aspeed-pwm-tacho.c:(.text+0x7f0): undefined reference to `thermal_of_cooling_device_register'
>
> This adds a dependency similar to what other hwmon drivers use,
> ensuring that the aspeed driver cannot be built-in in this
> case but has to be a module. With THERMAL=n, we still allow building it.
>
> Fixes: 2d7a548a3eff ("drivers: hwmon: Support for ASPEED PWM/Fan tach")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 5ef2814345ef..5b9a61f766ac 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -343,6 +343,7 @@ config SENSORS_ASB100
>
> config SENSORS_ASPEED
> tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> + depends on THERMAL || THERMAL=n
> select REGMAP
> help
> This driver provides support for ASPEED AST2400/AST2500 PWM
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-15 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 14:47 [PATCH] hwmon: aspeed: add THERMAL dependency Arnd Bergmann
2017-08-15 14:56 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).