linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: linux@roeck-us.net, jdelvare@suse.com,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	joel@jms.id.au, jk@ozlabs.org, andrew@aj.id.au,
	mark.rutland@arm.com, devicetree@vger.kernel.org, corbet@lwn.net,
	linux-doc@vger.kernel.org, "Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device
Date: Thu, 17 Aug 2017 10:11:16 -0500	[thread overview]
Message-ID: <20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop> (raw)
In-Reply-To: <1502403586-20549-2-git-send-email-eajames@linux.vnet.ibm.com>

On Thu, Aug 10, 2017 at 05:19:44PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
> 
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  .../devicetree/bindings/i2c/ibm,power-ps.txt        | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> new file mode 100644
> index 0000000..2ea8ea2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt
> @@ -0,0 +1,21 @@
> +Device-tree bindings for IBM POWER system power supplies
> +--------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,power-ps";
> + - reg = < I2C bus address >;		: Address of the power supply on the
> +					  I2C bus.
> +
> +Example:
> +
> +    i2c-bus@100 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        #interrupt-cells = <1>;
> +        < more properties >
> +
> +        power_ps@68 {

Don't use '_' in node names. Should be a generic name too if possible. 
Perhaps "power-supply".

> +            compatible = "ibm,power-ps";
> +            reg = <0x68>;
> +        };
> +    };
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2017-08-17 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 22:19 [PATCH v2 0/3] hwmon: (pmbus): Add POWER System power supply driver Eddie James
2017-08-10 22:19 ` [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device Eddie James
2017-08-17 15:11   ` Rob Herring [this message]
2017-08-21 18:35     ` Eddie James
2017-08-10 22:19 ` [PATCH v2 2/3] hwmon: (pmbus): Add POWER system power supply driver Eddie James
2017-08-11  1:18   ` Guenter Roeck
2017-08-11 14:30     ` Eddie James
2017-08-11 18:27       ` Guenter Roeck
2017-08-10 22:19 ` [PATCH v2 3/3] Documentation: hwmon: Add POWER system power supply documentation Eddie James
2017-08-11  1:19   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=andrew@aj.id.au \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.vnet.ibm.com \
    --cc=eajames@us.ibm.com \
    --cc=jdelvare@suse.com \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).