From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v2 05/19] perf, tools: Support weak groups
Date: Tue, 22 Aug 2017 10:34:15 +0200 [thread overview]
Message-ID: <20170822083415.GD23985@krava> (raw)
In-Reply-To: <20170811232634.30465-5-andi@firstfloor.org>
On Fri, Aug 11, 2017 at 04:26:20PM -0700, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/Documentation/perf-list.txt b/tools/perf/Documentation/perf-list.txt
> index f709de54707b..d432965d728d 100644
> --- a/tools/perf/Documentation/perf-list.txt
> +++ b/tools/perf/Documentation/perf-list.txt
> @@ -47,6 +47,7 @@ counted. The following modifiers exist:
> P - use maximum detected precise level
> S - read sample value (PERF_SAMPLE_READ)
> D - pin the event to the PMU
> + W - group is weak and will fallback to non-group if not schedulable
>
> The 'p' modifier can be used for specifying how precise the instruction
> address should be. The 'p' modifier can be specified multiple times:
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 866da7aa54bf..ac605caf1a01 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -582,6 +582,32 @@ static bool perf_evsel__should_store_id(struct perf_evsel *counter)
> return STAT_RECORD || counter->attr.read_format & PERF_FORMAT_ID;
> }
>
> +static struct perf_evsel *reset_weak_group(struct perf_evsel *counter)
> +{
> + struct perf_evsel *c2, *leader;
> + bool is_open = true;
> +
> + leader = counter->leader;
> + pr_debug("Weak group for %s/%d failed\n",
> + leader->name, counter->nr_members);
I'm getting 'branches/0' in here for you example:
[root@krava perf]# ./perf stat -v -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}:W' -a sleep 1
Using CPUID GenuineIntel-6-3D
l1d.replacement -> cpu/umask=0x1,period=2000003,event=0x51/
l2_lines_in.all -> cpu/umask=0x7,period=100003,event=0xf1/
l2_rqsts.all_code_rd -> cpu/umask=0xe4,period=200003,event=0x24/
Weak group for branches/0 failed
I'd expect nr_members == 5 ... any idea?
thanks,
jirka
next prev parent reply other threads:[~2017-08-22 8:34 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 23:26 [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Andi Kleen
2017-08-11 23:26 ` [PATCH v2 02/19] perf, tools: Fix buffer overflow while freeing events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-24 8:19 ` [tip:perf/core] perf evsel: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 03/19] perf, tools, stat: Fix saved values rbtree lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 04/19] perf, tools: Tighten detection of BPF events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 15:00 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf bpf: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 05/19] perf, tools: Support weak groups Andi Kleen
2017-08-22 8:34 ` Jiri Olsa [this message]
2017-08-22 20:58 ` Andi Kleen
2017-08-23 7:40 ` Jiri Olsa
2017-08-22 8:36 ` Jiri Olsa
2017-08-22 21:00 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 06/19] perf, tools: Add missing newline to expr parser error messages Andi Kleen
2017-08-11 23:26 ` [PATCH v2 07/19] perf, tools: Add utility function to detect SMT status Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 08/19] perf, tools: Expression parser enhancements for metrics Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-23 17:43 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 09/19] perf, tools: Increase maximum number of events in expressions Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:17 ` Arnaldo Carvalho de Melo
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 10/19] perf, tools: Dedup events in expression parsing Andi Kleen
2017-08-22 8:46 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 11/19] perf, tools: Support metric_group and no event name in json parser Andi Kleen
2017-08-11 23:26 ` [PATCH v2 12/19] perf, tools, stat: Factor out generic metric printing Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-11 23:26 ` [PATCH v2 13/19] perf, tools: Print generic metric header even for failed expressions Andi Kleen
2017-08-11 23:26 ` [PATCH v2 14/19] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen
2017-08-28 8:13 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:46 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 15/19] perf, tools, list: Add metric groups to perf list Andi Kleen
2017-08-11 23:26 ` [PATCH v2 16/19] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 17/19] perf, tools, stat: Support duration_time for metrics Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:47 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 18/19] perf, tools, stat: Hide internal duration_time counter Andi Kleen
2017-08-11 23:26 ` [PATCH v2 19/19] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen
2017-08-14 20:15 ` [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa
2017-08-14 20:39 ` Andi Kleen
2017-08-14 21:12 ` Jiri Olsa
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 14:40 ` Arnaldo Carvalho de Melo
2017-08-22 14:44 ` Jiri Olsa
2017-08-22 15:07 ` Arnaldo Carvalho de Melo
2017-08-24 8:19 ` [tip:perf/core] perf xyarray: Save max_x, max_y tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822083415.GD23985@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).