From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray
Date: Tue, 22 Aug 2017 16:44:16 +0200 [thread overview]
Message-ID: <20170822144416.GA13453@krava> (raw)
In-Reply-To: <20170822144050.GL10891@kernel.org>
On Tue, Aug 22, 2017 at 11:40:50AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 22, 2017 at 10:20:28AM +0200, Jiri Olsa escreveu:
> > On Fri, Aug 11, 2017 at 04:26:16PM -0700, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > > +static inline int xy_max_y(struct xyarray *xy)
> > > +{
> > > + return xy->max_x;
> > > +}
> > > +
> > > +static inline int xy_max_x(struct xyarray *xy)
> > > +{
> > > + return xy->max_y;
> > > +}
> >
> > I think you should follow the standard naming
> > and use xyarray__max_x and xyarray__max_y
>
> Yeah, will take just a bit longer to process, I'll fix that up...
fyi it's used in following patch
jirka
next prev parent reply other threads:[~2017-08-22 14:44 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 23:26 [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Andi Kleen
2017-08-11 23:26 ` [PATCH v2 02/19] perf, tools: Fix buffer overflow while freeing events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-24 8:19 ` [tip:perf/core] perf evsel: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 03/19] perf, tools, stat: Fix saved values rbtree lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 04/19] perf, tools: Tighten detection of BPF events Andi Kleen
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 15:00 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf bpf: " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 05/19] perf, tools: Support weak groups Andi Kleen
2017-08-22 8:34 ` Jiri Olsa
2017-08-22 20:58 ` Andi Kleen
2017-08-23 7:40 ` Jiri Olsa
2017-08-22 8:36 ` Jiri Olsa
2017-08-22 21:00 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 06/19] perf, tools: Add missing newline to expr parser error messages Andi Kleen
2017-08-11 23:26 ` [PATCH v2 07/19] perf, tools: Add utility function to detect SMT status Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-24 8:20 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 08/19] perf, tools: Expression parser enhancements for metrics Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:16 ` Arnaldo Carvalho de Melo
2017-08-23 17:43 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 09/19] perf, tools: Increase maximum number of events in expressions Andi Kleen
2017-08-22 8:45 ` Jiri Olsa
2017-08-22 15:17 ` Arnaldo Carvalho de Melo
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 10/19] perf, tools: Dedup events in expression parsing Andi Kleen
2017-08-22 8:46 ` Jiri Olsa
2017-08-24 8:21 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2017-08-11 23:26 ` [PATCH v2 11/19] perf, tools: Support metric_group and no event name in json parser Andi Kleen
2017-08-11 23:26 ` [PATCH v2 12/19] perf, tools, stat: Factor out generic metric printing Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-11 23:26 ` [PATCH v2 13/19] perf, tools: Print generic metric header even for failed expressions Andi Kleen
2017-08-11 23:26 ` [PATCH v2 14/19] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen
2017-08-28 8:13 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:46 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 15/19] perf, tools, list: Add metric groups to perf list Andi Kleen
2017-08-11 23:26 ` [PATCH v2 16/19] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen
2017-08-11 23:26 ` [PATCH v2 17/19] perf, tools, stat: Support duration_time for metrics Andi Kleen
2017-08-28 9:19 ` Jiri Olsa
2017-08-28 16:47 ` Andi Kleen
2017-08-11 23:26 ` [PATCH v2 18/19] perf, tools, stat: Hide internal duration_time counter Andi Kleen
2017-08-11 23:26 ` [PATCH v2 19/19] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen
2017-08-14 20:15 ` [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray Jiri Olsa
2017-08-14 20:39 ` Andi Kleen
2017-08-14 21:12 ` Jiri Olsa
2017-08-22 8:20 ` Jiri Olsa
2017-08-22 14:40 ` Arnaldo Carvalho de Melo
2017-08-22 14:44 ` Jiri Olsa [this message]
2017-08-22 15:07 ` Arnaldo Carvalho de Melo
2017-08-24 8:19 ` [tip:perf/core] perf xyarray: Save max_x, max_y tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822144416.GA13453@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).