linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Michael Bringmann <mwb@linux.vnet.ibm.com>
Subject: Re: [GIT PULL] workqueue fixes for v4.13-rc3
Date: Wed, 23 Aug 2017 07:24:22 -0700	[thread overview]
Message-ID: <20170823142421.GK491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CAMuHMdUGBug70nFxb7C0cyn7u2Q6Yoz4sONDtxHeV9H7stNYQw@mail.gmail.com>

Hello, Geert.

Something is really fishy.

On Wed, Aug 23, 2017 at 10:10:54AM +0200, Geert Uytterhoeven wrote:
> > +               pr_warn_once("WARNING: workqueue empty cpumask: node=%d cpu_going_down=%d cpumask=%*pb online=%*pb possible=%*pb\n",
> > +                            node, cpu_going_down, cpumask_pr_args(attrs->cpumask),
> > +                            cpumask_pr_args(cpumask_of_node(node)),
> > +                            cpumask_pr_args(wq_numa_possible_cpumask[node]));
> 
> WARNING: workqueue empty cpumask: node=1 cpu_going_down=-1 cpumask=1
> online=1 possible=0

So, somehow cpu0 seems to be associated with node 1 instead of 0.  It
seems highly unlikely but does the system actually have multiple NUMA
nodes?

> > @@ -5526,6 +5528,9 @@ static void __init wq_numa_init(void)
> >
> >         wq_numa_possible_cpumask = tbl;
> >         wq_numa_enabled = true;
> > +
> > +       for_each_node(node)
> > +               printk("XXX wq node[%d] %*pb\n", node, cpumask_pr_args(wq_numa_possible_cpumask[node]));
> 
> XXX wq node[0] 1
> XXX wq node[1] 0
> XXX wq node[2] 0
> XXX wq node[3] 0
> XXX wq node[4] 0
> XXX wq node[5] 0
> XXX wq node[6] 0
> XXX wq node[7] 0

No idea why num_possible_cpus() is 8 on a non-SMP system but the
problem is that, during boot while wq_numa_init() was running, cpu0
reported that it's associated with node 0, but later it reports that
it's associated node 1.  It looks like NUMA setup is screwed up.

Thanks.

-- 
tejun

  reply	other threads:[~2017-08-23 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 15:38 [GIT PULL] workqueue fixes for v4.13-rc3 Tejun Heo
2017-08-07 12:18 ` Geert Uytterhoeven
2017-08-07 17:06   ` Tejun Heo
2017-08-23  8:10     ` Geert Uytterhoeven
2017-08-23 14:24       ` Tejun Heo [this message]
2017-08-23 14:47         ` Geert Uytterhoeven
2017-08-23 17:08           ` Tejun Heo
2017-08-24 13:32             ` Geert Uytterhoeven
2017-08-24 14:33               ` Tejun Heo
2017-08-28  9:07                 ` Geert Uytterhoeven
2017-08-28 21:52                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823142421.GK491396@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwb@linux.vnet.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).