From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Michael Bringmann <mwb@linux.vnet.ibm.com>
Subject: Re: [GIT PULL] workqueue fixes for v4.13-rc3
Date: Wed, 23 Aug 2017 10:10:54 +0200 [thread overview]
Message-ID: <CAMuHMdUGBug70nFxb7C0cyn7u2Q6Yoz4sONDtxHeV9H7stNYQw@mail.gmail.com> (raw)
In-Reply-To: <20170807170659.GB537256@devbig577.frc2.facebook.com>
Hi Tejun,
On Mon, Aug 7, 2017 at 7:06 PM, Tejun Heo <tj@kernel.org> wrote:
> On Mon, Aug 07, 2017 at 02:18:51PM +0200, Geert Uytterhoeven wrote:
>> This triggers on m68k, which doesn't have SMP.
>> Haven't tried it yet on any other system due to holidays.
>
> That's weird. Can you please apply the following patch and report the
> messages?
>
> Thanks.
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index ca937b0..1b9d21b 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3579,8 +3579,10 @@ static bool wq_calc_node_cpumask(const struct workqueue_attrs *attrs, int node,
> cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
>
> if (cpumask_empty(cpumask)) {
> - pr_warn_once("WARNING: workqueue cpumask: online intersect > "
> - "possible intersect\n");
> + pr_warn_once("WARNING: workqueue empty cpumask: node=%d cpu_going_down=%d cpumask=%*pb online=%*pb possible=%*pb\n",
> + node, cpu_going_down, cpumask_pr_args(attrs->cpumask),
> + cpumask_pr_args(cpumask_of_node(node)),
> + cpumask_pr_args(wq_numa_possible_cpumask[node]));
WARNING: workqueue empty cpumask: node=1 cpu_going_down=-1 cpumask=1
online=1 possible=0
> return false;
> }
>
> @@ -5526,6 +5528,9 @@ static void __init wq_numa_init(void)
>
> wq_numa_possible_cpumask = tbl;
> wq_numa_enabled = true;
> +
> + for_each_node(node)
> + printk("XXX wq node[%d] %*pb\n", node, cpumask_pr_args(wq_numa_possible_cpumask[node]));
XXX wq node[0] 1
XXX wq node[1] 0
XXX wq node[2] 0
XXX wq node[3] 0
XXX wq node[4] 0
XXX wq node[5] 0
XXX wq node[6] 0
XXX wq node[7] 0
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-08-23 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 15:38 [GIT PULL] workqueue fixes for v4.13-rc3 Tejun Heo
2017-08-07 12:18 ` Geert Uytterhoeven
2017-08-07 17:06 ` Tejun Heo
2017-08-23 8:10 ` Geert Uytterhoeven [this message]
2017-08-23 14:24 ` Tejun Heo
2017-08-23 14:47 ` Geert Uytterhoeven
2017-08-23 17:08 ` Tejun Heo
2017-08-24 13:32 ` Geert Uytterhoeven
2017-08-24 14:33 ` Tejun Heo
2017-08-28 9:07 ` Geert Uytterhoeven
2017-08-28 21:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUGBug70nFxb7C0cyn7u2Q6Yoz4sONDtxHeV9H7stNYQw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwb@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).