From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@free-electrons.com,
thomas.petazzoni@free-electrons.com, andrew@lunn.ch,
gregory.clement@free-electrons.com, nadavh@marvell.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
mw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] net: mvpp2: fix the mac address retrieval logic
Date: Fri, 25 Aug 2017 15:58:48 +0200 [thread overview]
Message-ID: <20170825135848.GA31512@kwain> (raw)
In-Reply-To: <20170824.214624.250495333472785242.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
Hi Dave,
On Thu, Aug 24, 2017 at 09:46:24PM -0700, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@free-electrons.com>
> Date: Thu, 24 Aug 2017 11:46:54 +0200
>
> > The MAC address retrieval logic was broken and when using the PPv2
> > driver on PPv2.2 engines I ended up using the same mac address on all
> > ports. This series of patches fixes this, and also tackle a possible bug
> > when defining the mac address in the device tree.
> >
> > To fix this in a nice way I ended up using a dedicated function to
> > handle the mac retrieval logic. This can be hard to backport into stable
> > kernels. This is why I also made a quick fix which is easy to backport
> > (patch 1/14), to tackle down the PPv2.2 mac retrieval bug. Let me know
> > if this approach is the proper way to handle this or if I should do
> > something else.
>
> This patch series doesn't apply to any of my trees, that is the first
> thing.
That is very strange, my patches were based on top of net-next. I'll
double check if they apply correctly before sending the v2.
> Secondly, this is a bug fix, and the bug exists in the 'net' tree.
> Therefore this patch series should target the 'net' tree.
OK, that's the question I was asking. I'll resent everything to net
then.
> Please always target legitimate bug fixes at the 'net' tree, rather
> than 'net-next'.
Sure, will do.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-25 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 9:46 [PATCH net-next 0/4] net: mvpp2: fix the mac address retrieval logic Antoine Tenart
2017-08-24 9:46 ` [PATCH net-next 1/4] net: mvpp2: fix the mac address used when using PPv2.2 Antoine Tenart
2017-08-24 9:46 ` [PATCH net-next 2/4] net: mvpp2: move the mac retrieval/copy logic into its own function Antoine Tenart
2017-08-24 9:46 ` [PATCH net-next 3/4] net: mvpp2: fix use of the random mac address for PPv2.2 Antoine Tenart
2017-08-24 9:46 ` [PATCH net-next 4/4] net: mvpp2: fallback using h/w and random mac if the dt one isn't valid Antoine Tenart
2017-08-25 4:46 ` [PATCH net-next 0/4] net: mvpp2: fix the mac address retrieval logic David Miller
2017-08-25 13:58 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825135848.GA31512@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).