From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: David Ahern <dsahern@gmail.com>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Robert Elliott <elliott@hpe.com>
Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors
Date: Tue, 29 Aug 2017 07:27:20 -0700 [thread overview]
Message-ID: <20170829142720.GI491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170829124206.GA26738@lst.de>
Hello,
On Tue, Aug 29, 2017 at 02:42:06PM +0200, Christoph Hellwig wrote:
> We could try to check the IDENTIFY DEVICE word, but given that it has
> a dual meaning in older spec versions I don't really like the idea
> either. Untested patch below as I'm not near my OPAL capable drive.
I see.
> Also most recent ATA features seem to be keyed off a log page of some
> sort, so we'll run into more problems like this.
:(
> From e661047ec3a25587648b07c02a687a7dac778f3b Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 29 Aug 2017 14:35:50 +0200
> Subject: libata: check for trusted computing in IDENTIFY DEVICE data
>
> ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of
> the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE
> command to avoid issues with buggy devices. The only downside is that
> we can't support Security Send / Receive for a device with an older
> revision due to the conflicting use of this field in earlier
> specifications.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
David, can you please see whether this patch resolves your issue?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-08-29 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 18:40 boot failure with 4.13.0-rc6 due to ATA errors David Ahern
2017-08-28 19:59 ` Tejun Heo
2017-08-28 20:26 ` David Ahern
2017-08-28 21:22 ` Tejun Heo
2017-08-29 12:42 ` Christoph Hellwig
2017-08-29 14:27 ` Tejun Heo [this message]
2017-08-29 15:08 ` David Ahern
2017-08-29 15:30 ` Tejun Heo
2017-08-29 15:51 ` Henrique de Moraes Holschuh
2017-08-29 15:55 ` Tejun Heo
2017-08-29 16:02 ` Henrique de Moraes Holschuh
2017-08-29 15:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829142720.GI491396@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=dsahern@gmail.com \
--cc=elliott@hpe.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).