From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Tejun Heo <tj@kernel.org>
Cc: David Ahern <dsahern@gmail.com>, Christoph Hellwig <hch@lst.de>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Robert Elliott <elliott@hpe.com>
Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors
Date: Tue, 29 Aug 2017 12:51:02 -0300 [thread overview]
Message-ID: <20170829155102.vgbzyh7fhjrurdhl@khazad-dum.debian.net> (raw)
In-Reply-To: <20170829153037.GN491396@devbig577.frc2.facebook.com>
On Tue, 29 Aug 2017, Tejun Heo wrote:
> On Tue, Aug 29, 2017 at 09:08:05AM -0600, David Ahern wrote:
> > On 8/29/17 6:42 AM, Christoph Hellwig wrote:
> > > ---
> > > From e661047ec3a25587648b07c02a687a7dac778f3b Mon Sep 17 00:00:00 2001
> > > From: Christoph Hellwig <hch@lst.de>
> > > Date: Tue, 29 Aug 2017 14:35:50 +0200
> > > Subject: libata: check for trusted computing in IDENTIFY DEVICE data
> > >
> > > ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of
> > > the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE
> > > command to avoid issues with buggy devices. The only downside is that
> > > we can't support Security Send / Receive for a device with an older
> > > revision due to the conflicting use of this field in earlier
> > > specifications.
>
> Christoph, I'm gonna revert the horkage patch and apply this one. If
> you can think of a better way to do this, please let me know.
The one thing that comes to mind would be an additional patch to allow
people with ATA-7 to bypass the identify device data, and rely just on
the read log page check, based on a kernel command line parameter.
If we get enough sucessful reports to make it worth it, an whitelist
could be added...
--
Henrique Holschuh
next prev parent reply other threads:[~2017-08-29 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 18:40 boot failure with 4.13.0-rc6 due to ATA errors David Ahern
2017-08-28 19:59 ` Tejun Heo
2017-08-28 20:26 ` David Ahern
2017-08-28 21:22 ` Tejun Heo
2017-08-29 12:42 ` Christoph Hellwig
2017-08-29 14:27 ` Tejun Heo
2017-08-29 15:08 ` David Ahern
2017-08-29 15:30 ` Tejun Heo
2017-08-29 15:51 ` Henrique de Moraes Holschuh [this message]
2017-08-29 15:55 ` Tejun Heo
2017-08-29 16:02 ` Henrique de Moraes Holschuh
2017-08-29 15:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829155102.vgbzyh7fhjrurdhl@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dsahern@gmail.com \
--cc=elliott@hpe.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).