From: Mark Brown <broonie@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, ryan.lee.maxim@gmail.com
Subject: Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format
Date: Tue, 29 Aug 2017 20:00:15 +0100 [thread overview]
Message-ID: <20170829190015.kpscn3uuwbvwlp6e@sirena.org.uk> (raw)
In-Reply-To: <1503963061-14763-1-git-send-email-ryans.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote:
> + if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) ||
> + (max98927->iface == SND_SOC_DAIFMT_DSP_B))
> + return 0;
> +
> + /* BCLK configuration */
Why do we not configure the BCLK in DSP modes? That's unusual and seems
likely to break some systems that rely on exact clocking.
Also if we're selecting on format a switch statement is generally better
to make any further special casing easier in future.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-08-29 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 23:30 [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format Ryan Lee
2017-08-28 23:30 ` [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking Ryan Lee
2017-08-31 11:43 ` Mark Brown
2017-09-01 21:38 ` Ryan Lee
2017-08-28 23:30 ` [PATCH 3/9] ASoC: max98927: Updated volatile register list Ryan Lee
2017-08-28 23:30 ` [PATCH 4/9] ASoC: max98927: Added missing \n to end of dev_err messages Ryan Lee
2017-08-28 23:30 ` [PATCH 5/9] ASoC: max98927: Removed obsolete variables Ryan Lee
2017-08-31 11:53 ` Mark Brown
2017-09-01 21:38 ` Ryan Lee
2017-08-28 23:30 ` [PATCH 6/9] ASoC: max98927: Modified chip default register values Ryan Lee
2017-08-28 23:30 ` [PATCH 7/9] ASoC: max98927: Added PM suspend and resume function Ryan Lee
2017-08-28 23:31 ` [PATCH 8/9] ASoC: max98927: Modified DAPM widget and map to enable/disable VI sense path Ryan Lee
2017-08-28 23:31 ` [PATCH 9/9] ASoC: max98927: Changed device property read function Ryan Lee
2017-08-29 19:00 ` Mark Brown [this message]
2017-09-01 21:37 ` [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829190015.kpscn3uuwbvwlp6e@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).