From: Ryan Lee <RyanS.Lee@maximintegrated.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>
Subject: RE: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
Date: Fri, 1 Sep 2017 21:38:13 +0000 [thread overview]
Message-ID: <BY2PR11MB083746D8B7157462EDB24861E7920@BY2PR11MB0837.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20170831114357.dekzz4wa7j6vqi4t@sirena.org.uk>
>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Thursday, August 31, 2017 4:44 AM
>To: Ryan Lee <RyanS.Lee@maximintegrated.com>
>Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com;
>kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux-
>kernel@vger.kernel.org; ryan.lee.maxim@gmail.com
>Subject: Re: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking
>
>On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote:
>
>> /* Envelope Tracking configuration */
>> regmap_write(max98927->regmap,
>> MAX98927_R0082_ENV_TRACK_VOUT_HEADROOM,
>> - 0x08);
>> + 0x0A);
>> regmap_write(max98927->regmap,
>> MAX98927_R0086_ENV_TRACK_CTRL,
>> 0x01);
>> - regmap_write(max98927->regmap,
>> - MAX98927_R0087_ENV_TRACK_BOOST_VOUT_READ,
>> - 0x10);
>
>Why are we changing the defaults here? It was understandable to have a fixed
>default that differed from the chip value when there was no control but now
>there is a control and we're changing the default again for some undocumented
>reason. It'd be better to leave the values here to avoid breaking compatibility
>with existing users and let users who need different values change things using
>the newly added controls.
Thank you for feedback. Let me keep existing value.
I still need to remove regmap_write for R:0x87 because it is read-only register.
next prev parent reply other threads:[~2017-09-01 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 23:30 [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format Ryan Lee
2017-08-28 23:30 ` [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking Ryan Lee
2017-08-31 11:43 ` Mark Brown
2017-09-01 21:38 ` Ryan Lee [this message]
2017-08-28 23:30 ` [PATCH 3/9] ASoC: max98927: Updated volatile register list Ryan Lee
2017-08-28 23:30 ` [PATCH 4/9] ASoC: max98927: Added missing \n to end of dev_err messages Ryan Lee
2017-08-28 23:30 ` [PATCH 5/9] ASoC: max98927: Removed obsolete variables Ryan Lee
2017-08-31 11:53 ` Mark Brown
2017-09-01 21:38 ` Ryan Lee
2017-08-28 23:30 ` [PATCH 6/9] ASoC: max98927: Modified chip default register values Ryan Lee
2017-08-28 23:30 ` [PATCH 7/9] ASoC: max98927: Added PM suspend and resume function Ryan Lee
2017-08-28 23:31 ` [PATCH 8/9] ASoC: max98927: Modified DAPM widget and map to enable/disable VI sense path Ryan Lee
2017-08-28 23:31 ` [PATCH 9/9] ASoC: max98927: Changed device property read function Ryan Lee
2017-08-29 19:00 ` [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format Mark Brown
2017-09-01 21:37 ` Ryan Lee
-- strict thread matches above, loose matches on Subject: below --
2017-08-26 0:41 [PATCH 1/9] ASoC: max98927: Added TDM support Ryan Lee
2017-08-26 0:41 ` [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY2PR11MB083746D8B7157462EDB24861E7920@BY2PR11MB0837.namprd11.prod.outlook.com \
--to=ryans.lee@maximintegrated.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).