From: Borislav Petkov <bp@alien8.de>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac
Date: Thu, 31 Aug 2017 18:52:01 +0200 [thread overview]
Message-ID: <20170831165201.rbbkacrz3vt7xuqg@pd.tnic> (raw)
In-Reply-To: <1504195625.2042.179.camel@hpe.com>
On Thu, Aug 31, 2017 at 04:17:07PM +0000, Kani, Toshimitsu wrote:
> I followed in the footsteps of 'ghes_disable', which is also a kernel
> boot option and uses 0.
Ok, ghes_disable comment says that using module_param() is easier.
ghes_edac is not a module but then __setup() is for "really core code".
Documentation/admin-guide/kernel-parameters.rst also talks about
core_param() but that's #ifndef MODULE. So module_param() it is.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-08-31 16:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 22:54 [PATCH v4 0/5] enable ghes_edac on selected platforms Toshi Kani
2017-08-23 22:54 ` [PATCH v4 1/5] ACPI / blacklist: add acpi_match_platform_list() Toshi Kani
2017-08-24 7:53 ` Borislav Petkov
2017-08-28 20:55 ` Rafael J. Wysocki
2017-08-28 21:21 ` Borislav Petkov
2017-08-28 21:19 ` Rafael J. Wysocki
2017-08-23 22:54 ` [PATCH v4 2/5] intel_pstate: convert to use acpi_match_platform_list() Toshi Kani
2017-08-23 22:54 ` [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Toshi Kani
2017-08-31 10:56 ` Borislav Petkov
2017-08-31 16:17 ` Kani, Toshimitsu
2017-08-31 16:52 ` Borislav Petkov [this message]
2017-08-23 22:54 ` [PATCH v4 4/5] EDAC: add edac_get_owner() to check MC owner Toshi Kani
2017-08-23 22:54 ` [PATCH v4 5/5] edac drivers: add MC owner check in init Toshi Kani
2017-09-01 9:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831165201.rbbkacrz3vt7xuqg@pd.tnic \
--to=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).