From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac
Date: Thu, 31 Aug 2017 16:17:07 +0000 [thread overview]
Message-ID: <1504195625.2042.179.camel@hpe.com> (raw)
In-Reply-To: <20170831105647.a7ypixekv6jybqyu@pd.tnic>
On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote:
> On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote:
:
> > ---
> > drivers/edac/ghes_edac.c | 29 ++++++++++++++++++++++++-----
> > 1 file changed, 24 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> > index 8d904df..0030a09 100644
> > --- a/drivers/edac/ghes_edac.c
> > +++ b/drivers/edac/ghes_edac.c
> > @@ -38,6 +38,10 @@ static struct ghes_edac_pvt *ghes_pvt;
> > */
> > static DEFINE_SPINLOCK(ghes_lock);
> >
> > +/* Set 1 to skip the platform check */
> > +static bool __read_mostly ghes_edac_force_load;
>
> It is static - "force_load" as a bool name is enough.
Will do.
> > +module_param_named(force_load, ghes_edac_force_load, bool, 0);
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #53: FILE: drivers/edac/ghes_edac.c:43:
> +module_param_named(force_load, ghes_edac_force_load, bool, 0);
>
> This last param is @perm: visibility in sysfs. Why not visible in
> sysfs?
I followed in the footsteps of 'ghes_disable', which is also a kernel
boot option and uses 0.
> > +
> > /* Memory Device - Type 17 of SMBIOS spec */
> > struct memdev_dmi_entry {
> > u8 type;
> > @@ -415,6 +419,15 @@ void ghes_edac_report_mem_error(struct ghes
> > *ghes, int sev,
> > spin_unlock_irqrestore(&ghes_lock, flags);
> > }
> >
> > +/*
> > + * Known systems that are safe to enable this module.
> > + * "ghes_edac.force_load=1" skips this check if necessary.
>
> Put this second sentence over the parameter definition.
Will do.
Thanks,
-Toshi
next prev parent reply other threads:[~2017-08-31 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 22:54 [PATCH v4 0/5] enable ghes_edac on selected platforms Toshi Kani
2017-08-23 22:54 ` [PATCH v4 1/5] ACPI / blacklist: add acpi_match_platform_list() Toshi Kani
2017-08-24 7:53 ` Borislav Petkov
2017-08-28 20:55 ` Rafael J. Wysocki
2017-08-28 21:21 ` Borislav Petkov
2017-08-28 21:19 ` Rafael J. Wysocki
2017-08-23 22:54 ` [PATCH v4 2/5] intel_pstate: convert to use acpi_match_platform_list() Toshi Kani
2017-08-23 22:54 ` [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Toshi Kani
2017-08-31 10:56 ` Borislav Petkov
2017-08-31 16:17 ` Kani, Toshimitsu [this message]
2017-08-31 16:52 ` Borislav Petkov
2017-08-23 22:54 ` [PATCH v4 4/5] EDAC: add edac_get_owner() to check MC owner Toshi Kani
2017-08-23 22:54 ` [PATCH v4 5/5] edac drivers: add MC owner check in init Toshi Kani
2017-09-01 9:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504195625.2042.179.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).