From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Antony Antony <antony@phenome.org>
Cc: Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support
Date: Tue, 5 Sep 2017 13:09:17 +0200 [thread overview]
Message-ID: <20170905110917.pjf22akyqiytx3iu@flea> (raw)
In-Reply-To: <20170904143014.46904-1-antony@phenome.org>
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
Hi Antony,
Almost good, I'm sorry I missed a few things before.
On Mon, Sep 04, 2017 at 04:30:14PM +0200, Antony Antony wrote:
> +&mmc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc1_pins_a>;
> + vmmc-supply = <®_vcc3v3>;
> + vqmmc-supply = <®_vcc3v3>;
> + mmc-pwrseq = <&wifi_pwrseq>;
> + bus-width = <4>;
> + non-removable;
> + status = "okay";
Please add a new line here.
> + brcmf: wifi@1 {
> + reg = <1>;
> + compatible = "brcm";
This should be the actual compatible, not just the vendor.
> + };
> +};
> +
> +&mmc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc2_8bit_pins>;
> + vmmc-supply = <®_vcc3v3>;
> + bus-width = <8>;
> + non-removable;
> + cap-mmc-hw-reset;
> + boot_device = <0>;
that property should still be removed.
> +&r_pio {
> + leds_r_npi: led_pins@0 {
> + pins = "PL10";
> + function = "gpio_out";
> + };
> +
> + vdd_cpux_r_npi: regulator_pins@0 {
> + allwinner,pins = "PL6";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +};
And these must be left out.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-09-05 11:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170824231716.2623-1-antony@phenome.org>
2017-08-25 10:32 ` [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus 2 Antony Antony
2017-08-25 12:05 ` Corentin Labbe
2017-08-25 17:47 ` Antony Antony
2017-08-25 13:28 ` Code Kipper
2017-08-25 17:42 ` Antony Antony
2017-08-28 12:16 ` Antony Antony
2017-08-28 12:18 ` Icenowy Zheng
2017-08-29 21:51 ` Antony Antony
2017-08-26 11:11 ` [PATCH v3] " Antony Antony
2017-08-28 12:19 ` [PATCH v4] arm64: allwinner: h5: add support for NanoPi NEO Plus2 Antony Antony
2017-08-30 12:50 ` [PATCH v5] " Antony Antony
2017-08-31 14:58 ` Maxime Ripard
2017-09-01 10:53 ` Antony Antony
2017-09-04 8:27 ` Maxime Ripard
2017-09-04 14:26 ` Antony Antony
2017-09-05 11:04 ` Maxime Ripard
2017-09-01 10:58 ` [PATCH] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support Antony Antony
2017-09-01 20:45 ` [PATCH v7] " Antony Antony
2017-09-04 14:30 ` [PATCH v8] " Antony Antony
2017-09-05 11:09 ` Maxime Ripard [this message]
2017-09-07 16:42 ` [PATCH v9] " Antony Antony
2017-09-08 14:49 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905110917.pjf22akyqiytx3iu@flea \
--to=maxime.ripard@free-electrons.com \
--cc=antony@phenome.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).